pidgin/pidgin

Fix memory leak when creating an IRCv3 account
default tip
31 hours ago, Markus Fischer
96d1ed6df91c
Fix memory leak when creating an IRCv3 account

Testing Done:
Created a new IRCv3 account while running in valgrind.

Reviewed at https://reviews.imfreedom.org/r/3262/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This library is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this library; if not, see <https://www.gnu.org/licenses/>.
*/
#include <glib.h>
#include <glib/gi18n-lib.h>
#include <gplugin.h>
#include <gplugin-native.h>
#include <purple.h>
#include "purpleircv3core.h"
#include "purpleircv3connection.h"
#include "purpleircv3protocol.h"
/******************************************************************************
* Globals
*****************************************************************************/
static PurpleProtocol *ircv3_protocol = NULL;
/******************************************************************************
* GPlugin Exports
*****************************************************************************/
static GPluginPluginInfo *
purple_ircv3_query(G_GNUC_UNUSED GError **error) {
PurplePluginInfoFlags flags = PURPLE_PLUGIN_INFO_FLAGS_INTERNAL |
PURPLE_PLUGIN_INFO_FLAGS_AUTO_LOAD;
const gchar * const authors[] = {
"Pidgin Developers <devel@pidgin.im>",
NULL
};
return purple_plugin_info_new(
"id", "prpl-ircv3",
"name", "IRCv3 Protocol",
"authors", authors,
"version", DISPLAY_VERSION,
"category", N_("Protocol"),
"summary", N_("IRCv3 Protocol Plugin"),
"description", N_("Modern IRC Support"),
"website", PURPLE_WEBSITE,
"abi-version", PURPLE_ABI_VERSION,
"flags", flags,
"bind-global", TRUE,
NULL);
}
static gboolean
purple_ircv3_load(GPluginPlugin *plugin, GError **error) {
PurpleProtocolManager *manager = NULL;
if(PURPLE_IS_PROTOCOL(ircv3_protocol)) {
g_set_error_literal(error, PURPLE_IRCV3_DOMAIN, 0,
"plugin was not cleaned up properly");
return FALSE;
}
purple_ircv3_connection_register(GPLUGIN_NATIVE_PLUGIN(plugin));
purple_ircv3_protocol_register(GPLUGIN_NATIVE_PLUGIN(plugin));
ircv3_protocol = purple_ircv3_protocol_new();
manager = purple_protocol_manager_get_default();
/* Manager can be NULL when we're generating the GIR stuff. */
if(PURPLE_IS_PROTOCOL_MANAGER(manager)) {
if(!purple_protocol_manager_register(manager, ircv3_protocol, error)) {
g_clear_object(&ircv3_protocol);
return FALSE;
}
}
return TRUE;
}
static gboolean
purple_ircv3_unload(G_GNUC_UNUSED GPluginPlugin *plugin,
G_GNUC_UNUSED gboolean shutdown,
GError **error)
{
PurpleProtocolManager *manager = NULL;
if(!PURPLE_IS_PROTOCOL(ircv3_protocol)) {
g_set_error_literal(error, PURPLE_IRCV3_DOMAIN, 0,
"plugin was not setup properly");
return FALSE;
}
manager = purple_protocol_manager_get_default();
/* Manager can be NULL when we're generating the GIR stuff. */
if(PURPLE_IS_PROTOCOL_MANAGER(manager)) {
if(!purple_protocol_manager_unregister(manager, ircv3_protocol,
error))
{
return FALSE;
}
}
g_clear_object(&ircv3_protocol);
return TRUE;
}
GPLUGIN_NATIVE_PLUGIN_DECLARE(purple_ircv3)