Moves to a nicely spaced `GtkListBox`. The avatar is implemented using `AdwAvatar` solely for the autogenerated colour for accounts without an icon to give them some uniqueness, but it could be moved to `PidginAvatar`.
As a followup, I'd probably move the Account Editors from a separate dialog to stack within the manager, similar to how the Plugin dialog works. Neither the previous manager nor this one prevents you from opening two editors for an account, but this would remove that issue as well.
Testing Done:
Toggled enabled/disabled to check that account status worked and was displayed. Added a few bogus accounts to confirm that errors are shown. Activated a row to show the editor. Hit the delete button and cancelled/approved and confirmed that account was kept/removed.
Reviewed at https://reviews.imfreedom.org/r/2079/
/*
* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*
*/
#ifdef HAVE_CONFIG_H
#include<config.h>
#endif
#include<errno.h>
#include<glib/gi18n-lib.h>
#include<glib/gstdio.h>
#include<locale.h>
#include<purple.h>
#include"pidginapplication.h"
#include"pidgincore.h"
#ifndef _WIN32
#include<signal.h>
#endif
#ifndef _WIN32
/*
* Lists of signals we wish to catch and those we wish to ignore.
* Each list terminated with -1
*/
staticconstintcatch_sig_list[]={
SIGSEGV,
SIGINT,
SIGTERM,
SIGQUIT,
SIGCHLD,
-1
};
staticconstintignore_sig_list[]={
SIGPIPE,
-1
};
#endif /* !_WIN32 */
#ifndef _WIN32
staticchar*segfault_message;
staticguintsignal_channel_watcher;
staticintsignal_sockets[2];
staticvoidsighandler(intsig);
staticvoidsighandler(intsig)
{
ssize_twritten;
/*
* We won't do any of the heavy lifting for the signal handling here
* because we have no idea what was interrupted. Previously this signal
* handler could result in some calls to malloc/free, which can cause
* deadlock in libc when the signal handler was interrupting a previous
* malloc or free. So instead we'll do an ugly hack where we write the
* signal number to one end of a socket pair. The other half of the
* socket pair is watched by our main loop. When the main loop sees new
* data on the socket it reads in the signal and performs the appropriate