pidgin/pidgin

Fix leak in Status Manager dialog

15 months ago, Elliott Sales de Andrade
eafcc5051015
Fix leak in Status Manager dialog

Fix the leak of the GObject wrapper
```
580 (72 direct, 508 indirect) bytes in 3 blocks are definitely lost in loss record 30,987 of 34,328
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x48B79DF: pidgin_status_manager_add (pidginstatusmanager.c:138)
by 0x48B7B2A: pidgin_status_manager_populate_helper (pidginstatusmanager.c:158)
by 0x496801F: g_list_foreach (glist.c:1092)
by 0x48B7B74: pidgin_status_manager_refresh (pidginstatusmanager.c:169)
```

Testing Done:
Ran valgrind, opened Statuses and an editor for a status, and the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2301/
{
X oddness 1
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:_XReply
}
{
X oddness 2
Memcheck:Param
writev(vector[...])
fun:writev
obj:/usr/X11R6/lib/libX11.so.6.2
fun:_X11TransWritev
fun:_XSend
}
{
X oddness 3
Memcheck:Cond
fun:XcursorImageHash
fun:XcursorNoticePutBitmap
fun:_XNoticePutBitmap
fun:XPutImage
}
{
X oddness 4
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:XFlush
}
{
X oddness 5
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:XDrawLine
}
{
X oddness 6
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:_XEventsQueued
}
{
File selector
Memcheck:Value4
fun:_itoa_word
fun:_IO_vfprintf_internal
fun:_IO_vsprintf_internal
fun:_IO_sprintf
}
{
File selector 2
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:XRenderComposite
}
{
FontConfig Maybe
Memcheck:Leak
fun:malloc
fun:FcStrCopy
fun:FcStrSetAdd
fun:FcLangSetCopy
}
{
File selector 3
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:_XFlushGCCache
}
{
File selector 4
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:XCreateGC
}
{
Something else
Memcheck:Param
write(buf)
fun:__write_nocancel
fun:_X11TransWrite
obj:/usr/X11R6/lib/libX11.so.6.2
fun:_XSetClipRectangles
}
{
libfontconfig leaks
Memcheck:Leak
fun:*alloc
obj:/usr/lib/libfontconfig.so.*
...
}
{
wcslen_sse2 optimization
Memcheck:Addr8
fun:__wcslen_sse2
...
}
{
wcslen_sse2 optimization 2
Memcheck:Cond
fun:__wcslen_sse2
...
}
{
idna bug
Memcheck:Addr4
fun:idna_to_ascii_4z
fun:idna_to_ascii_8z
...
}
{
libcairo uninitialized values
Memcheck:Cond
obj:*libpixman-1.so.*
obj:*libpixman-1.so.*
obj:*libpixman-1.so.*
obj:*libpixman-1.so.*
fun:pixman_image_composite32
obj:*libcairo.so.2.*
obj:*libcairo.so.2.*
obj:*libcairo.so.2.*
obj:*libcairo.so.2.*
obj:*
}
{
librsvg uninitialized values
Memcheck:Cond
obj:*librsvg-2.so.2.*
fun:rsvg_handle_get_pixbuf_sub
fun:rsvg_handle_get_pixbuf
obj:*
}