pidgin/pidgin

Fix leak in Status Manager dialog

15 months ago, Elliott Sales de Andrade
eafcc5051015
Fix leak in Status Manager dialog

Fix the leak of the GObject wrapper
```
580 (72 direct, 508 indirect) bytes in 3 blocks are definitely lost in loss record 30,987 of 34,328
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x48B79DF: pidgin_status_manager_add (pidginstatusmanager.c:138)
by 0x48B7B2A: pidgin_status_manager_populate_helper (pidginstatusmanager.c:158)
by 0x496801F: g_list_foreach (glist.c:1092)
by 0x48B7B74: pidgin_status_manager_refresh (pidginstatusmanager.c:169)
```

Testing Done:
Ran valgrind, opened Statuses and an editor for a status, and the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2301/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include <stdio.h>
#include <glib.h>
#include <glib/gstdio.h>
#include <glib/gi18n-lib.h>
#include <purple.h>
#define PURPLE_COMPILATION
#include "../libpurple/purpleprivate.h"
#undef PURPLE_COMPILATION
/******************************************************************************
* Helpers
*****************************************************************************/
static gboolean
purple_history_query(const gchar *query, GError **error) {
PurpleHistoryManager *manager = purple_history_manager_get_default();
GList *results = NULL;
results = purple_history_manager_query(manager, query, error);
if(error != NULL) {
return FALSE;
}
while(results != NULL) {
PurpleMessage *message = PURPLE_MESSAGE(results->data);
g_printf("%s: %s\n", purple_message_get_author(message),
purple_message_get_contents(message));
g_clear_object(&message);
results = g_list_delete_link(results, results);
}
return TRUE;
}
G_GNUC_UNUSED
static gboolean
purple_history_remove(const gchar *query, GError **error) {
PurpleHistoryManager *manager = purple_history_manager_get_default();
gboolean success = FALSE;
success = purple_history_manager_remove(manager, query, error);
if(!success) {
return FALSE;
}
if(error) {
g_printf("Remove successful\n");
}
return TRUE;
}
/******************************************************************************
* Main
*****************************************************************************/
gint
main(gint argc, gchar *argv[]) {
GError *error = NULL;
GOptionContext *ctx = NULL;
GOptionGroup *group = NULL;
gint exit_code = EXIT_SUCCESS;
ctx = g_option_context_new(_("QUERY"));
g_option_context_set_help_enabled(ctx, TRUE);
g_option_context_set_summary(ctx, _("Query purple message history"));
g_option_context_set_translation_domain(ctx, GETTEXT_PACKAGE);
group = purple_get_option_group();
g_option_context_add_group(ctx, group);
g_option_context_parse(ctx, &argc, &argv, &error);
g_option_context_free(ctx);
if(error != NULL) {
g_fprintf(stderr, "%s\n", error->message);
g_clear_error(&error);
return EXIT_FAILURE;
}
purple_history_manager_startup();
for(gint i = 1; i < argc; i++) {
if(argv[i] == NULL || *argv[i] == '\0') {
continue;
}
if(!purple_history_query(argv[i], &error)) {
fprintf(stderr, "query failed: %s\n",
error ? error->message : "unknown error");
g_clear_error(&error);
exit_code = EXIT_FAILURE;
}
}
purple_history_manager_shutdown();
return exit_code;
}