pidgin/pidgin

Update the demo protocol plugin to not depend on conversation names
default tip
19 hours ago, Gary Kramlich
f755b10c05a3
Update the demo protocol plugin to not depend on conversation names

We're starting to phase out conversation names as they don't work well with
modern stuff. So this goes ahead and fixes the not interactions in the demo
protocol.

I also generated the echo message in the send_message_async rather than in the
callback.

Testing Done:
Ran the turtles and send some messages to Echo on the demo protocol.

Reviewed at https://reviews.imfreedom.org/r/3135/
/*
* Pidgin - Internet Messenger
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include <glib/gi18n-lib.h>
#include <gtk/gtk.h>
#include "pidginaccountchooser.h"
struct _PidginAccountChooser {
AdwBin parent;
GtkDropDown *chooser;
GtkFilterListModel *filter;
};
enum
{
PROP_0,
PROP_ACCOUNT,
PROP_FILTER,
N_PROPERTIES,
};
static GParamSpec *properties[N_PROPERTIES] = {NULL, };
/******************************************************************************
* Callbacks
*****************************************************************************/
static void
pidgin_account_chooser_changed_cb(G_GNUC_UNUSED GObject *obj,
G_GNUC_UNUSED GParamSpec *pspec,
gpointer data)
{
g_object_notify_by_pspec(G_OBJECT(data), properties[PROP_ACCOUNT]);
}
/******************************************************************************
* GObject implementation
*****************************************************************************/
G_DEFINE_FINAL_TYPE(PidginAccountChooser, pidgin_account_chooser, ADW_TYPE_BIN)
static void
pidgin_account_chooser_get_property(GObject *object, guint prop_id,
GValue *value, GParamSpec *pspec)
{
PidginAccountChooser *chooser = PIDGIN_ACCOUNT_CHOOSER(object);
switch (prop_id) {
case PROP_ACCOUNT:
g_value_set_object(value, pidgin_account_chooser_get_selected(chooser));
break;
case PROP_FILTER:
g_value_set_object(value, pidgin_account_chooser_get_filter(chooser));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
break;
}
}
static void
pidgin_account_chooser_set_property(GObject *object, guint prop_id,
const GValue *value, GParamSpec *pspec)
{
PidginAccountChooser *chooser = PIDGIN_ACCOUNT_CHOOSER(object);
switch (prop_id) {
case PROP_ACCOUNT:
pidgin_account_chooser_set_selected(chooser,
g_value_get_object(value));
break;
case PROP_FILTER:
pidgin_account_chooser_set_filter(chooser,
g_value_get_object(value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
break;
}
}
static void
pidgin_account_chooser_class_init(PidginAccountChooserClass *klass)
{
GObjectClass *obj_class = G_OBJECT_CLASS(klass);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
/* Properties */
obj_class->get_property = pidgin_account_chooser_get_property;
obj_class->set_property = pidgin_account_chooser_set_property;
/**
* PidginAccountChooser:account:
*
* The account that is currently selected.
*
* Since: 3.0
*/
properties[PROP_ACCOUNT] = g_param_spec_object(
"account", "Account",
"The account that is currently selected.",
PURPLE_TYPE_ACCOUNT,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
/**
* PidginAccountChooser:filter:
*
* A filter to be applied to the list of accounts.
*
* Since: 3.0
*/
properties[PROP_FILTER] = g_param_spec_object(
"filter", "filter",
"The filter to be applied on the list of accounts.",
GTK_TYPE_FILTER,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
g_object_class_install_properties(obj_class, N_PROPERTIES, properties);
/* Widget template */
gtk_widget_class_set_template_from_resource(
widget_class, "/im/pidgin/Pidgin3/Accounts/chooser.ui");
gtk_widget_class_bind_template_child(widget_class, PidginAccountChooser,
chooser);
gtk_widget_class_bind_template_child(widget_class, PidginAccountChooser,
filter);
gtk_widget_class_bind_template_callback(widget_class,
pidgin_account_chooser_changed_cb);
}
static void
pidgin_account_chooser_init(PidginAccountChooser *chooser) {
GListModel *model = NULL;
gtk_widget_init_template(GTK_WIDGET(chooser));
model = purple_account_manager_get_default_as_model();
gtk_filter_list_model_set_model(chooser->filter, model);
}
/******************************************************************************
* Public API
*****************************************************************************/
GtkWidget *
pidgin_account_chooser_new(void) {
PidginAccountChooser *chooser = NULL;
chooser = g_object_new(PIDGIN_TYPE_ACCOUNT_CHOOSER, NULL);
return GTK_WIDGET(chooser);
}
GtkFilter *
pidgin_account_chooser_get_filter(PidginAccountChooser *chooser) {
g_return_val_if_fail(PIDGIN_IS_ACCOUNT_CHOOSER(chooser), NULL);
return gtk_filter_list_model_get_filter(chooser->filter);
}
void
pidgin_account_chooser_set_filter(PidginAccountChooser *chooser,
GtkFilter *filter)
{
g_return_if_fail(PIDGIN_IS_ACCOUNT_CHOOSER(chooser));
gtk_filter_list_model_set_filter(chooser->filter, filter);
g_object_notify_by_pspec(G_OBJECT(chooser), properties[PROP_FILTER]);
}
PurpleAccount *
pidgin_account_chooser_get_selected(PidginAccountChooser *chooser) {
g_return_val_if_fail(PIDGIN_IS_ACCOUNT_CHOOSER(chooser), NULL);
return gtk_drop_down_get_selected_item(chooser->chooser);
}
void
pidgin_account_chooser_set_selected(PidginAccountChooser *chooser,
PurpleAccount *account)
{
GListModel *model = NULL;
guint n_items = 0;
g_return_if_fail(PIDGIN_IS_ACCOUNT_CHOOSER(chooser));
model = gtk_drop_down_get_model(chooser->chooser);
g_return_if_fail(G_IS_LIST_MODEL(model));
n_items = g_list_model_get_n_items(model);
for(guint position = 0; position < n_items; position++) {
PurpleAccount *acc = g_list_model_get_item(model, position);
if(acc == account) {
/* NOTE: Property notification occurs in 'changed' signal
* callback.
*/
gtk_drop_down_set_selected(chooser->chooser, position);
g_object_unref(acc);
return;
}
g_object_unref(acc);
}
}