pidgin/pidgin

Cleanup RoomList UI ops

2021-07-02, Elliott Sales de Andrade
dd0f04c5d212
Cleanup RoomList UI ops

* Mark unused parameters, and remove unnecessary widgets passed to callbacks.
* Remove unused `purple_roomlist_[gs]et_protocol_data`.
* Remove unused list of `PurpleRoomList`s.
* Inline `update_roomlist` using GObject macros.
* Remove use of `PurpleRoomListUiOps->destroy`.
This can be achieved through object destruction notifiers.
I'm not sure how the room list would ever get destroyed in Finch though, as the
widget seems to hold a ref to it, which is cleared when the list is destroyed.
But the list can't be destroyed until said ref is dropped.
* Replace `PurpleRoomlistUiOps->in_progress` with notify signals.

Testing Done:
Compile only. Might have done some tests, but I wrote this a while back and don't remember.

Reviewed at https://reviews.imfreedom.org/r/785/
/*
* Pidgin - Internet Messenger
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include "pidgin/pidginpresence.h"
/******************************************************************************
* Public API
*****************************************************************************/
const gchar *
pidgin_presence_get_icon_name(PurplePresence *presence, const gchar *fallback) {
PurpleStatus *status = NULL;
PurpleStatusType *type = NULL;
if(!PURPLE_IS_PRESENCE(presence)) {
return fallback;
}
status = purple_presence_get_active_status(presence);
if(!PURPLE_IS_STATUS(status)) {
return fallback;
}
type = purple_status_get_status_type(status);
if(type == NULL) {
return fallback;
}
switch(purple_status_type_get_primitive(type)) {
case PURPLE_STATUS_OFFLINE:
return "pidgin-user-offline";
break;
case PURPLE_STATUS_AVAILABLE:
return "pidgin-user-available";
break;
case PURPLE_STATUS_UNAVAILABLE:
return "pidgin-user-unavailable";
break;
case PURPLE_STATUS_AWAY:
return "pidgin-user-away";
break;
case PURPLE_STATUS_INVISIBLE:
return "pidgin-user-invisible";
break;
case PURPLE_STATUS_EXTENDED_AWAY:
return "pidgin-user-extended-away";
break;
case PURPLE_STATUS_MOBILE:
case PURPLE_STATUS_TUNE:
case PURPLE_STATUS_MOOD:
case PURPLE_STATUS_UNSET:
default:
break;
}
return fallback;
}