pidgin/pidgin

Cleanup RoomList UI ops

2021-07-02, Elliott Sales de Andrade
dd0f04c5d212
Cleanup RoomList UI ops

* Mark unused parameters, and remove unnecessary widgets passed to callbacks.
* Remove unused `purple_roomlist_[gs]et_protocol_data`.
* Remove unused list of `PurpleRoomList`s.
* Inline `update_roomlist` using GObject macros.
* Remove use of `PurpleRoomListUiOps->destroy`.
This can be achieved through object destruction notifiers.
I'm not sure how the room list would ever get destroyed in Finch though, as the
widget seems to hold a ref to it, which is cleared when the list is destroyed.
But the list can't be destroyed until said ref is dropped.
* Replace `PurpleRoomlistUiOps->in_progress` with notify signals.

Testing Done:
Compile only. Might have done some tests, but I wrote this a while back and don't remember.

Reviewed at https://reviews.imfreedom.org/r/785/
---
id: im.pidgin.Pidgin3
runtime: org.gnome.Platform
runtime-version: '3.36'
sdk: org.gnome.Sdk
command: pidgin3
finish-args:
- --share=ipc
- --socket=fallback-x11
- --share=network
- --socket=pulseaudio
- --talk-name=org.freedesktop.Notifications
- --system-talk-name=org.freedesktop.Avahi
modules:
- packaging/flatpak/libpurple-common.yml
- packaging/flatpak/talkatu.yml
- name: pidgin3
buildsystem: meson
config-opts:
- -Dconsoleui=false
- -Ddoc=false
sources:
- type: dir
path: '.'