pidgin/pidgin

Cleanup RoomList UI ops

2021-07-02, Elliott Sales de Andrade
dd0f04c5d212
Cleanup RoomList UI ops

* Mark unused parameters, and remove unnecessary widgets passed to callbacks.
* Remove unused `purple_roomlist_[gs]et_protocol_data`.
* Remove unused list of `PurpleRoomList`s.
* Inline `update_roomlist` using GObject macros.
* Remove use of `PurpleRoomListUiOps->destroy`.
This can be achieved through object destruction notifiers.
I'm not sure how the room list would ever get destroyed in Finch though, as the
widget seems to hold a ref to it, which is cleared when the list is destroyed.
But the list can't be destroyed until said ref is dropped.
* Replace `PurpleRoomlistUiOps->in_progress` with notify signals.

Testing Done:
Compile only. Might have done some tests, but I wrote this a while back and don't remember.

Reviewed at https://reviews.imfreedom.org/r/785/
/*
* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include <glib/gi18n-lib.h>
#include "pidginwindow.h"
#include "pidgincore.h"
struct _PidginWindow {
GtkWindow parent;
};
/******************************************************************************
* GObject Implementation
*****************************************************************************/
G_DEFINE_TYPE(PidginWindow, pidgin_window, GTK_TYPE_WINDOW)
static void
pidgin_window_init(PidginWindow *button) {
}
static void
pidgin_window_class_init(PidginWindowClass *klass) {
}
/******************************************************************************
* Public API
*****************************************************************************/
GtkWidget *
pidgin_window_new(const gchar *title, guint border_width, const gchar *role,
gboolean resizable)
{
if(title == NULL) {
title = PIDGIN_ALERT_TITLE;
}
return GTK_WIDGET(g_object_new(
PIDGIN_TYPE_WINDOW,
"title", title,
"border-width", border_width,
"role", role,
"resizable", resizable,
NULL));
}