pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
.bad-filter {
color: @error_fg_color;
text-shadow: 0 1px @error_text_shadow;
background-image: none;
background-color: @error_bg_color;
}
.good-filter {
color: @question_fg_color;
text-shadow: 0 1px @question_text_shadow;
background-image: none;
background-color: @success_color;
}