pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
pidginpixmapdir = get_option('datadir') / 'pixmaps/pidgin'
subdir('emotes')
if INSTALL_PIXMAPS
install_data('logo.png', 'arrow-down.xpm', 'arrow-left.xpm', 'arrow-right.xpm', 'arrow-up.xpm',
install_dir : pidginpixmapdir)
# Some of these don't use install_subdir because it deletes the target,
# and some target directories probably have something in them, for those
# installing somewhere with existing stuff. Additionally, we have
# extra stuff in our directories we don't want to install.
install_data('edit.png', 'info.png', 'pause.png',
install_dir : pidginpixmapdir / 'buttons')
subdir('tray')
endif