pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
/*
* pidgin
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, it can be viewed online at
* https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
*/
#ifndef PIDGIN_PIDGIN_H
#define PIDGIN_PIDGIN_H
/**
* SECTION:pidgin
* @section_id: libpurple-purple
* @short_description: <filename>pidgin.h</filename>
* @title: Global header for Pidgin
*
* This file contains all the necessary preprocessor directives to include
* Pidgin's headers and other preprocessor directives required for plugins
* to build. Including this file eliminates the need to directly include any
* other Pidgin files.
*/
#include <glib.h>
#ifndef __GI_SCANNER__
# ifdef PIDGIN_COMPILATION
# error "pidgin source files should not be including pidgin.h"
# endif /* PIDGIN_COMPILATION */
#endif /* __GI_SCANNER__ */
#ifndef PIDGIN_GLOBAL_HEADER_INSIDE
# define PIDGIN_GLOBAL_HEADER_INSIDE
#endif /* PIDGIN_GLOBAL_HEADER_INSIDE */
@PIDGIN_H_INCLUDES@
#undef PIDGIN_GLOBAL_HEADER_INSIDE
#endif /* PIDGIN_PIDGIN_H */