pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
/* This file is part of the Project Athena Zephyr Notification System.
* It contains source for the ZSendNotice function.
*
* Created by: Robert French
*
* Copyright (c) 1987 by the Massachusetts Institute of Technology.
* For copying and distribution information, see the file
* "mit-copyright.h".
*/
#include "internal.h"
Code_t
ZSendNotice(ZNotice_t *notice, Z_AuthProc cert_routine)
{
return(ZSrvSendNotice(notice, cert_routine, Z_XmitFragment));
}
Code_t
ZSrvSendNotice(ZNotice_t *notice, Z_AuthProc cert_routine,
Code_t (*send_routine)())
{
Code_t retval;
ZNotice_t newnotice;
char *buffer;
int len;
if ((retval = ZFormatNotice(notice, &buffer, &len,
cert_routine)) != ZERR_NONE)
return (retval);
if ((retval = ZParseNotice(buffer, len, &newnotice)) != ZERR_NONE)
return (retval);
retval = Z_SendFragmentedNotice(&newnotice, len, cert_routine,
send_routine);
free(buffer);
return (retval);
}