pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
/* This file is part of the Project Athena Zephyr Notification System.
* It contains source for ZPeekPacket function.
*
* Created by: Robert French
*
* Copyright (c) 1987 by the Massachusetts Institute of Technology.
* For copying and distribution information, see the file
* "mit-copyright.h".
*/
#include "internal.h"
Code_t
ZPeekPacket(char **buffer, int *ret_len, GSocketAddress **from)
{
Code_t retval;
Z_InputQ *nextq;
if ((retval = Z_WaitForComplete()) != ZERR_NONE)
return (retval);
nextq =Z_GetFirstComplete();
*ret_len = nextq->packet_len;
if (!(*buffer = (char *) malloc((unsigned) *ret_len)))
return (ENOMEM);
(void) memcpy(*buffer, nextq->packet, *ret_len);
if (from) {
*from = g_object_ref(nextq->from);
}
return (ZERR_NONE);
}