pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
/* This file is part of the Project Athena Zephyr Notification System.
* It contains source for the ZGetSubscriptions function.
*
* Created by: Robert French
*
* Copyright (c) 1987 by the Massachusetts Institute of Technology.
* For copying and distribution information, see the file
* "mit-copyright.h".
*/
#include "internal.h"
Code_t ZGetSubscriptions(ZSubscription_t *subscription, int *numsubs)
{
int i;
if (!__subscriptions_list) {
return (ZERR_NOSUBSCRIPTIONS);
}
if (__subscriptions_next == __subscriptions_num) {
return (ZERR_NOMORESUBSCRIPTIONS);
}
for (i = 0; i < MIN(*numsubs, __subscriptions_num - __subscriptions_next);
i++) {
subscription[i] = __subscriptions_list[i + __subscriptions_next];
}
if (__subscriptions_num - __subscriptions_next < *numsubs) {
*numsubs = __subscriptions_num - __subscriptions_next;
}
__subscriptions_next += *numsubs;
return ZERR_NONE;
}