pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
/* This file is part of the Project Athena Zephyr Notification System.
* It contains source for the ZFormatRawNoticeList function.
*
* Created by: Robert French
*
* Copyright (c) 1987 by the Massachusetts Institute of Technology.
* For copying and distribution information, see the file
* "mit-copyright.h".
*/
#include "internal.h"
Code_t
ZFormatRawNoticeList(ZNotice_t *notice, char *list[], int nitems, char **buffer,
int *ret_len)
{
char header[Z_MAXHEADERLEN];
int hdrlen, i, size;
char *ptr;
Code_t retval;
if ((retval = Z_FormatRawHeader(notice, header, sizeof(header),
&hdrlen, NULL, NULL)) != ZERR_NONE)
return (retval);
size = 0;
for (i=0;i<nitems;i++)
size += strlen(list[i])+1;
*ret_len = hdrlen+size;
if (!(*buffer = (char *) malloc((unsigned) *ret_len)))
return (ENOMEM);
(void) memcpy(*buffer, header, hdrlen);
ptr = *buffer+hdrlen;
for (;nitems;nitems--, list++) {
i = strlen(*list)+1;
(void) memcpy(ptr, *list, i);
ptr += i;
}
return (ZERR_NONE);
}