pidgin/pidgin

Avoid manual handling of icons in request field list items

2021-04-05, Arkadiy Illarionov
b5eccef8404e
Avoid manual handling of icons in request field list items

* Use `PurpleKeyValuePair` as field list items
* Replace `icons` list with `has_icons` flag, thus fixing memleak
* Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`

Testing Done:
Compile and run.

Reviewed at https://reviews.imfreedom.org/r/563/
foreach prog : ['caps', 'digest_md5', 'scram', 'jutil']
e = executable(
'test_jabber_' + prog, 'test_jabber_@0@.c'.format(prog),
link_with : [jabber_prpl],
dependencies : [libxml, libpurple_dep, libsoup, glib])
test('jabber_' + prog, e)
endforeach