pidgin/pidgin

Convert PidginStatusBox to a GtkMenuButton

13 months ago, Elliott Sales de Andrade
adf6d358d438
Convert PidginStatusBox to a GtkMenuButton

This moves to a menu system to populate the list of statuses, and the new `PidginStatusDisplay` to show them. I tried a `GtkDropDown` previously, but that was unable to show the separators that we previously had. Consequently, it uses actions a bit more then before.

However, since menus don't support icons+text at the same time, and doesn't have a factory property, we do need to manually create custom widgets a bit, but it's mostly only a button + the `PidginStatusDisplay`.

The main display is now centred, but there seems to be nothing we can do about that, as the box with that alignment is internal to the `GtkMenuButton`. If we don't want that, we could switch to managing a `GtkToggleButton` and `GtkPopoverMenu` ourselves.

Testing Done:
Opened status box and confirmed that all primitives and saved statuses were there as expected.
Modified a status, and confirmed that the menu updated to match.
Added/deleted statuses from the manager and confirmed they menu updated to match.
Chose the New Status/Saved Statuses menu items and confirmed they opened the correct dialogs.
Picked a bunch of statuses from the menu items and confirmed the main display updated, and some updates were sent out to protocols (e.g. Demo disconnecting when offline, etc.)

Reviewed at https://reviews.imfreedom.org/r/2386/
/*
* Pidgin - Internet Messenger
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include <pidgin/pidginstatusprimitivechooser.h>
#include <pidgin/pidginiconname.h>
struct _PidginStatusPrimitiveChooser {
AdwComboRow parent;
};
G_DEFINE_TYPE(PidginStatusPrimitiveChooser, pidgin_status_primitive_chooser,
ADW_TYPE_COMBO_ROW)
/******************************************************************************
* Callbacks
*****************************************************************************/
static PurpleStatusPrimitive
pidgin_status_primitive_chooser_primitive_cb(G_GNUC_UNUSED GObject *self,
GtkStringObject *object,
G_GNUC_UNUSED gpointer data)
{
PurpleStatusPrimitive primitive = PURPLE_STATUS_UNSET;
if(GTK_IS_STRING_OBJECT(object)) {
const char *value = gtk_string_object_get_string(object);
primitive = purple_primitive_get_type_from_id(value);
}
return primitive;
}
/******************************************************************************
* GObject Implementation
*****************************************************************************/
static void
pidgin_status_primitive_chooser_init(PidginStatusPrimitiveChooser *chooser) {
gtk_widget_init_template(GTK_WIDGET(chooser));
}
static void
pidgin_status_primitive_chooser_class_init(PidginStatusPrimitiveChooserClass *klass) {
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
/* Widget template */
gtk_widget_class_set_template_from_resource(
widget_class, "/im/pidgin/Pidgin3/statusprimitivechooser.ui");
gtk_widget_class_bind_template_callback(widget_class,
pidgin_status_primitive_chooser_primitive_cb);
}
/******************************************************************************
* Public API
*****************************************************************************/
GtkWidget *
pidgin_status_primitive_chooser_new(void) {
return g_object_new(PIDGIN_TYPE_STATUS_PRIMITIVE_CHOOSER, NULL);
}
PurpleStatusPrimitive
pidgin_status_primitive_chooser_get_selected(PidginStatusPrimitiveChooser *chooser) {
GtkStringObject *selected = NULL;
const char *value = NULL;
g_return_val_if_fail(PIDGIN_IS_STATUS_PRIMITIVE_CHOOSER(chooser),
PURPLE_STATUS_UNSET);
selected = adw_combo_row_get_selected_item(ADW_COMBO_ROW(chooser));
value = gtk_string_object_get_string(selected);
return purple_primitive_get_type_from_id(value);
}
void
pidgin_status_primitive_chooser_set_selected(PidginStatusPrimitiveChooser *chooser,
PurpleStatusPrimitive primitive)
{
GListModel *model = NULL;
GtkStringList *list = NULL;
g_return_if_fail(PIDGIN_IS_STATUS_PRIMITIVE_CHOOSER(chooser));
model = adw_combo_row_get_model(ADW_COMBO_ROW(chooser));
list = GTK_STRING_LIST(model);
for(guint i = 0; i < g_list_model_get_n_items(model); i++) {
PurpleStatusPrimitive candidate = PURPLE_STATUS_UNSET;
const char *value = NULL;
value = gtk_string_list_get_string(list, i);
candidate = purple_primitive_get_type_from_id(value);
if(primitive == candidate) {
adw_combo_row_set_selected(ADW_COMBO_ROW(chooser), i);
break;
}
}
}