pidgin/pidgin

Convert PidginStatusBox to a GtkMenuButton

14 months ago, Elliott Sales de Andrade
adf6d358d438
Convert PidginStatusBox to a GtkMenuButton

This moves to a menu system to populate the list of statuses, and the new `PidginStatusDisplay` to show them. I tried a `GtkDropDown` previously, but that was unable to show the separators that we previously had. Consequently, it uses actions a bit more then before.

However, since menus don't support icons+text at the same time, and doesn't have a factory property, we do need to manually create custom widgets a bit, but it's mostly only a button + the `PidginStatusDisplay`.

The main display is now centred, but there seems to be nothing we can do about that, as the box with that alignment is internal to the `GtkMenuButton`. If we don't want that, we could switch to managing a `GtkToggleButton` and `GtkPopoverMenu` ourselves.

Testing Done:
Opened status box and confirmed that all primitives and saved statuses were there as expected.
Modified a status, and confirmed that the menu updated to match.
Added/deleted statuses from the manager and confirmed they menu updated to match.
Chose the New Status/Saved Statuses menu items and confirmed they opened the correct dialogs.
Picked a bunch of statuses from the menu items and confirmed the main display updated, and some updates were sent out to protocols (e.g. Demo disconnecting when offline, etc.)

Reviewed at https://reviews.imfreedom.org/r/2386/
/* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#if !defined(PIDGIN_GLOBAL_HEADER_INSIDE) && !defined(PIDGIN_COMPILATION)
# error "only <pidgin.h> may be included directly"
#endif
#ifndef PIDGIN_PLUGIN_INFO_H
#define PIDGIN_PLUGIN_INFO_H
#include <gtk/gtk.h>
#include <gplugin.h>
#include <purple.h>
G_BEGIN_DECLS
/**
* PidginPluginInfo:
*
* A #GPluginPluginInfo subclass that adds some Pidgin specific properties.
*
* Since: 3.0.0
*/
#define PIDGIN_TYPE_PLUGIN_INFO (pidgin_plugin_info_get_type())
G_DECLARE_FINAL_TYPE(PidginPluginInfo, pidgin_plugin_info, PIDGIN, PLUGIN_INFO, PurplePluginInfo)
/**
* PidginPluginInfoGetConfigFrameFunc:
* @plugin: The instance of the plugin.
*
* Gets the [class@Gtk.Widget] for configruing @plugin.
*
* Returns: (transfer full): The widget used to configure @plugin.
*
* Since: 3.0.0
*/
typedef GtkWidget *(*PidginPluginInfoGetConfigFrameFunc)(PurplePlugin *plugin);
/**
* pidgin_plugin_info_new:
* @first_property: The first property name
* @...: The value of the first property, followed optionally by more
* name/value pairs, followed by %NULL
*
* Creates a new #PidginPluginInfo instance to be returned from
* #plugin_query of a pidgin plugin, using the provided name/value
* pairs.
*
* See purple_plugin_info_new() for a list of available property names.
* Additionally, you can provide the property
* <literal>"gtk-config-frame-cb"</literal>, which should be a callback that
* returns a #GtkWidget for the plugin's configuration
* (see #PidginPluginConfigFrameCb).
*
* See purple_plugin_info_new().
*
* Returns: A new #PidginPluginInfo instance.
*
* Since: 3.0.0
*/
GPluginPluginInfo *pidgin_plugin_info_new(const char *first_property, ...) G_GNUC_NULL_TERMINATED;
G_END_DECLS
#endif /* PIDGIN_PLUGIN_INFO_H */