HGKeeper

Convert PidginStatusBox to a GtkMenuButton

13 months ago, Elliott Sales de Andrade

adf6d358d438

Executable

Convert PidginStatusBox to a GtkMenuButton

This moves to a menu system to populate the list of statuses, and the new `PidginStatusDisplay` to show them. I tried a `GtkDropDown` previously, but that was unable to show the separators that we previously had. Consequently, it uses actions a bit more then before.

However, since menus don't support icons+text at the same time, and doesn't have a factory property, we do need to manually create custom widgets a bit, but it's mostly only a button + the `PidginStatusDisplay`.

The main display is now centred, but there seems to be nothing we can do about that, as the box with that alignment is internal to the `GtkMenuButton`. If we don't want that, we could switch to managing a `GtkToggleButton` and `GtkPopoverMenu` ourselves.

Testing Done:
Opened status box and confirmed that all primitives and saved statuses were there as expected.
Modified a status, and confirmed that the menu updated to match.
Added/deleted statuses from the manager and confirmed they menu updated to match.
Chose the New Status/Saved Statuses menu items and confirmed they opened the correct dialogs.
Picked a bunch of statuses from the menu items and confirmed the main display updated, and some updates were sent out to protocols (e.g. Demo disconnecting when offline, etc.)

Reviewed at https://reviews.imfreedom.org/r/2386/

#!/usr/bin/env python3

# Purple is the legal property of its developers, whose names are too numerous

# to list here. Please refer to the COPYRIGHT file distributed with this

# source distribution.

# This program is free software; you can redistribute it and/or modify

# it under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 2 of the License, or

# (at your option) any later version.

# This program is distributed in the hope that it will be useful,

# but WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License

# along with this program; if not, write to the Free Software

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA

"""

Produce meson-config.h in a build directory.

This should not really be run manually. It is used by Meson as a

post-configuration script to create meson-config.h which for now simply

contains information about the configuration used to create the build

directory.

"""

import html

import json

import os

import shlex

import subprocess

import sys

try:

introspect = os.environ['MESONINTROSPECT']

except KeyError:

print('Meson is too old; '

'it does not set MESONINTROSPECT for postconf scripts.')

sys.exit(1)

else:

introspect = shlex.split(introspect)

try:

build_root = os.environ['MESON_BUILD_ROOT']

except KeyError:

print('Meson is too old; '

'it does not set MESON_BUILD_ROOT for postconf scripts.')

sys.exit(1)

def tostr(obj):

if isinstance(obj, str):

return html.escape(repr(obj))

else:

return repr(obj)

conf = subprocess.check_output(introspect + ['--buildoptions', build_root],

universal_newlines=True)

conf = json.loads(conf)

settings = ' '.join('{}={}'.format(option['name'], tostr(option['value']))

for option in sorted(conf, key=lambda x: x['name']))

with open(os.path.join(build_root, 'meson-config.h'), 'w') as f:

f.write('#define MESON_ARGS "{}"'.format(settings))

pidgin/pidgin