pidgin/pidgin

Convert PidginStatusBox to a GtkMenuButton

13 months ago, Elliott Sales de Andrade
adf6d358d438
Convert PidginStatusBox to a GtkMenuButton

This moves to a menu system to populate the list of statuses, and the new `PidginStatusDisplay` to show them. I tried a `GtkDropDown` previously, but that was unable to show the separators that we previously had. Consequently, it uses actions a bit more then before.

However, since menus don't support icons+text at the same time, and doesn't have a factory property, we do need to manually create custom widgets a bit, but it's mostly only a button + the `PidginStatusDisplay`.

The main display is now centred, but there seems to be nothing we can do about that, as the box with that alignment is internal to the `GtkMenuButton`. If we don't want that, we could switch to managing a `GtkToggleButton` and `GtkPopoverMenu` ourselves.

Testing Done:
Opened status box and confirmed that all primitives and saved statuses were there as expected.
Modified a status, and confirmed that the menu updated to match.
Added/deleted statuses from the manager and confirmed they menu updated to match.
Chose the New Status/Saved Statuses menu items and confirmed they opened the correct dialogs.
Picked a bunch of statuses from the menu items and confirmed the main display updated, and some updates were sent out to protocols (e.g. Demo disconnecting when offline, etc.)

Reviewed at https://reviews.imfreedom.org/r/2386/
---
id: im.pidgin.Pidgin3
runtime: org.gnome.Platform
runtime-version: '3.36'
sdk: org.gnome.Sdk
command: pidgin3
finish-args:
- --share=ipc
- --socket=fallback-x11
- --share=network
- --socket=pulseaudio
- --talk-name=org.freedesktop.Notifications
- --system-talk-name=org.freedesktop.Avahi
modules:
- packaging/flatpak/libpurple-common.yml
- packaging/flatpak/talkatu.yml
- name: pidgin3
buildsystem: meson
config-opts:
- -Dconsoleui=false
- -Ddoc=false
sources:
- type: dir
path: '.'