pidgin/pidgin

Convert PidginStatusBox to a GtkMenuButton

14 months ago, Elliott Sales de Andrade
adf6d358d438
Convert PidginStatusBox to a GtkMenuButton

This moves to a menu system to populate the list of statuses, and the new `PidginStatusDisplay` to show them. I tried a `GtkDropDown` previously, but that was unable to show the separators that we previously had. Consequently, it uses actions a bit more then before.

However, since menus don't support icons+text at the same time, and doesn't have a factory property, we do need to manually create custom widgets a bit, but it's mostly only a button + the `PidginStatusDisplay`.

The main display is now centred, but there seems to be nothing we can do about that, as the box with that alignment is internal to the `GtkMenuButton`. If we don't want that, we could switch to managing a `GtkToggleButton` and `GtkPopoverMenu` ourselves.

Testing Done:
Opened status box and confirmed that all primitives and saved statuses were there as expected.
Modified a status, and confirmed that the menu updated to match.
Added/deleted statuses from the manager and confirmed they menu updated to match.
Chose the New Status/Saved Statuses menu items and confirmed they opened the correct dialogs.
Picked a bunch of statuses from the menu items and confirmed the main display updated, and some updates were sent out to protocols (e.g. Demo disconnecting when offline, etc.)

Reviewed at https://reviews.imfreedom.org/r/2386/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "purpleaccountusersplit.h"
/******************************************************************************
* Structs
*****************************************************************************/
struct _PurpleAccountUserSplit {
gchar *text;
gchar *default_value;
gchar field_sep;
gboolean reverse;
gboolean constant;
};
/******************************************************************************
* Public API
*****************************************************************************/
G_DEFINE_BOXED_TYPE(
PurpleAccountUserSplit,
purple_account_user_split,
purple_account_user_split_copy,
purple_account_user_split_destroy
);
PurpleAccountUserSplit *
purple_account_user_split_new(const gchar *text, const gchar *default_value, gchar sep)
{
PurpleAccountUserSplit *split;
g_return_val_if_fail(text != NULL, NULL);
g_return_val_if_fail(sep != 0, NULL);
split = g_new0(PurpleAccountUserSplit, 1);
split->text = g_strdup(text);
split->field_sep = sep;
split->default_value = g_strdup(default_value);
split->reverse = TRUE;
return split;
}
PurpleAccountUserSplit *
purple_account_user_split_copy(PurpleAccountUserSplit *split) {
PurpleAccountUserSplit *newsplit = NULL;
newsplit = purple_account_user_split_new(split->text, split->default_value, split->field_sep);
newsplit->reverse = split->reverse;
newsplit->constant = split->constant;
return newsplit;
}
void
purple_account_user_split_destroy(PurpleAccountUserSplit *split)
{
g_return_if_fail(split != NULL);
g_free(split->text);
g_free(split->default_value);
g_free(split);
}
const gchar *
purple_account_user_split_get_text(PurpleAccountUserSplit *split)
{
g_return_val_if_fail(split != NULL, NULL);
return split->text;
}
const gchar *
purple_account_user_split_get_default_value(PurpleAccountUserSplit *split)
{
g_return_val_if_fail(split != NULL, NULL);
return split->default_value;
}
char
purple_account_user_split_get_separator(PurpleAccountUserSplit *split)
{
g_return_val_if_fail(split != NULL, 0);
return split->field_sep;
}
gboolean
purple_account_user_split_get_reverse(PurpleAccountUserSplit *split)
{
g_return_val_if_fail(split != NULL, FALSE);
return split->reverse;
}
void
purple_account_user_split_set_reverse(PurpleAccountUserSplit *split, gboolean reverse)
{
g_return_if_fail(split != NULL);
split->reverse = reverse;
}
gboolean
purple_account_user_split_is_constant(PurpleAccountUserSplit *split)
{
g_return_val_if_fail(split != NULL, FALSE);
return split->constant;
}
void
purple_account_user_split_set_constant(PurpleAccountUserSplit *split,
gboolean constant)
{
g_return_if_fail(split != NULL);
split->constant = constant;
}