pidgin/pidgin

Fix a crash on shutdown in kwallet if the wallet was never opened.

2021-03-23, Gary Kramlich
a6a5e36ddfe5
Fix a crash on shutdown in kwallet if the wallet was never opened.

The wallet instance variable was not initialized so if the wallet was never opened we were trying to delete and invalid pointer.

Also update the dispose method of the provider to close the wallet as the
tasks in the queue hold a reference to the provider instance as the source
object in their tasks.

Testing Done:
Ran locally with both the kwallet and secret service providers.

Reviewed at https://reviews.imfreedom.org/r/581/
/*
* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#ifndef PURPLE_ACCOUNT_PRESENCE_H
#define PURPLE_ACCOUNT_PRESENCE_H
/**
* SECTION:purpleaccountpresence
* @section_id: libpurple-purpleaccountpresence
* @title: Account Presence API
*
* A #PurpleAccountPresence represent the #PurplePresence for a specific
* #PurpleAccount.
*/
#include "account.h"
#include "purplepresence.h"
G_BEGIN_DECLS
/**
* PurpleAccountPresence:
*
* A presence for an account
*/
/**
* PURPLE_TYPE_ACCOUNT_PRESENCE:
*
* The standard _get_type macro for #PurpleAccountPresence.
*/
#define PURPLE_TYPE_ACCOUNT_PRESENCE (purple_account_presence_get_type())
/**
* purple_account_presence_get_type:
*
* Returns: The #GType for the #PurpleAccountPresence object.
*/
G_DECLARE_FINAL_TYPE(PurpleAccountPresence, purple_account_presence, PURPLE,
ACCOUNT_PRESENCE, PurplePresence)
/**
* purple_account_presence_new:
* @account: The account to associate with the presence.
*
* Creates a presence for an account.
*
* Returns: The new presence.
*
* Since: 3.0.0
*/
PurpleAccountPresence *purple_account_presence_new(PurpleAccount *account);
/**
* purple_account_presence_get_account:
* @presence: The presence.
*
* Returns an account presence's account.
*
* Returns: (transfer none): The presence's account.
*/
PurpleAccount *purple_account_presence_get_account(PurpleAccountPresence *presence);
G_END_DECLS
#endif /* PURPLE_ACCOUNT_PRESENCE_H */