HGKeeper

Fix a crash on shutdown in kwallet if the wallet was never opened.

2021-03-23, Gary Kramlich

a6a5e36ddfe5

Fix a crash on shutdown in kwallet if the wallet was never opened.

The wallet instance variable was not initialized so if the wallet was never opened we were trying to delete and invalid pointer.

Also update the dispose method of the provider to close the wallet as the
tasks in the queue hold a reference to the provider instance as the source
object in their tasks.

Testing Done:
Ran locally with both the kwallet and secret service providers.

Reviewed at https://reviews.imfreedom.org/r/581/

silcpurple.h

Author: Pekka Riikonen <priikone@silcnet.org>

This program is free software; you can redistribute it and/or modify

it under the terms of the GNU General Public License as published by

the Free Software Foundation; version 2 of the License.

This program is distributed in the hope that it will be useful,

but WITHOUT ANY WARRANTY; without even the implied warranty of

MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

GNU General Public License for more details.

#ifndef PURPLE_SILC_WB_H

#define PURPLE_SILC_WB_H

#include "silcpurple.h"

PurpleWhiteboard *

silcpurple_wb_init(SilcPurple sg, SilcClientEntry client_entry);

PurpleWhiteboard *

silcpurple_wb_init_ch(SilcPurple sg, SilcChannelEntry channel);

void silcpurple_wb_receive(SilcClient client, SilcClientConnection conn,

SilcClientEntry sender, SilcMessagePayload payload,

SilcMessageFlags flags, const unsigned char *message,

SilcUInt32 message_len);

void silcpurple_wb_receive_ch(SilcClient client, SilcClientConnection conn,

SilcClientEntry sender, SilcChannelEntry channel,

SilcMessagePayload payload,

SilcMessageFlags flags,

const unsigned char *message,

SilcUInt32 message_len);

void silcpurple_wb_start(PurpleWhiteboard *wb);

void silcpurple_wb_end(PurpleWhiteboard *wb);

void silcpurple_wb_get_dimensions(const PurpleWhiteboard *wb, int *width, int *height);

void silcpurple_wb_set_dimensions(PurpleWhiteboard *wb, int width, int height);

void silcpurple_wb_get_brush(const PurpleWhiteboard *wb, int *size, int *color);

void silcpurple_wb_set_brush(PurpleWhiteboard *wb, int size, int color);

void silcpurple_wb_send(PurpleWhiteboard *wb, GList *draw_list);

void silcpurple_wb_clear(PurpleWhiteboard *wb);

#endif /* PURPLE_SILC_WB_H */

pidgin/pidgin