pidgin/pidgin

Fix a crash on shutdown in kwallet if the wallet was never opened.

2021-03-23, Gary Kramlich
a6a5e36ddfe5
Fix a crash on shutdown in kwallet if the wallet was never opened.

The wallet instance variable was not initialized so if the wallet was never opened we were trying to delete and invalid pointer.

Also update the dispose method of the provider to close the wallet as the
tasks in the queue hold a reference to the provider instance as the source
object in their tasks.

Testing Done:
Ran locally with both the kwallet and secret service providers.

Reviewed at https://reviews.imfreedom.org/r/581/
/*
* nmconference.c
*
* Copyright (c) 2004 Novell, Inc. All Rights Reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*
*/
#include <string.h>
#include "nmconference.h"
static int conf_count = 0;
struct _NMConference
{
/* The conference identifier */
char *guid;
/* The list of participants for the conference */
GSList *participants;
/* Flags for the conference */
guint32 flags;
/* User defined data */
gpointer data;
/* Reference count for this object */
int ref_count;
};
/*******************************************************************************
* Conference API -- see header file for comments
******************************************************************************/
NMConference *
nm_create_conference(const char *guid)
{
NMConference *conf = g_new0(NMConference, 1);
if (guid) {
conf->guid = g_strdup(guid);
} else {
conf->guid = g_strdup(BLANK_GUID);
}
conf->ref_count = 1;
purple_debug_info("novell", "Creating a conference %p, total=%d",
conf, conf_count++);
return conf;
}
void
nm_release_conference(NMConference * conference)
{
GSList *node;
g_return_if_fail(conference != NULL);
purple_debug_info("novell", "In release conference %p, refs=%d",
conference, conference->ref_count);
if (--conference->ref_count == 0) {
purple_debug_info("novell", "Releasing conference %p, total=%d",
conference, --conf_count);
g_free(conference->guid);
if (conference->participants) {
for (node = conference->participants; node; node = node->next) {
if (node->data) {
NMUserRecord *user_record = node->data;
nm_release_user_record(user_record);
node->data = NULL;
}
}
g_slist_free(conference->participants);
}
g_free(conference);
}
}
gboolean
nm_conference_is_instantiated(NMConference * conference)
{
if (conference == NULL)
return FALSE;
return (strncmp(conference->guid, BLANK_GUID, CONF_GUID_END) != 0);
}
int
nm_conference_get_participant_count(NMConference * conference)
{
if (conference == NULL)
return 0;
return g_slist_length(conference->participants);
}
NMUserRecord *
nm_conference_get_participant(NMConference * conference, int index)
{
if (conference == NULL)
return NULL;
return (NMUserRecord *) g_slist_nth_data(conference->participants, index);
}
void
nm_conference_add_participant(NMConference * conference,
NMUserRecord * user_record)
{
if (conference == NULL || user_record == NULL) {
return;
}
nm_user_record_add_ref(user_record);
conference->participants = g_slist_append(conference->participants, user_record);
}
void
nm_conference_remove_participant(NMConference * conference, const char *dn)
{
GSList *node, *element = NULL;
if (conference == NULL || dn == NULL) {
return;
}
for (node = conference->participants; node; node = node->next) {
NMUserRecord *user_record = node->data;
if (user_record) {
if (nm_utf8_str_equal(dn, nm_user_record_get_dn(user_record))) {
element = node;
break;
}
}
}
if (element) {
nm_release_user_record((NMUserRecord *) element->data);
element->data = NULL;
conference->participants =
g_slist_delete_link(conference->participants, element);
}
}
void
nm_conference_add_ref(NMConference * conference)
{
if (conference)
conference->ref_count++;
}
void
nm_conference_set_flags(NMConference * conference, guint32 flags)
{
if (conference) {
conference->flags = flags;
}
}
void
nm_conference_set_guid(NMConference * conference, const char *guid)
{
if (conference) {
/* Release memory for old guid */
g_free(conference->guid);
/* Set the new guid */
if (guid)
conference->guid = g_strdup(guid);
else
conference->guid = g_strdup(BLANK_GUID);
}
}
void
nm_conference_set_data(NMConference * conference, gpointer data)
{
if (conference == NULL)
return;
conference->data = data;
}
gpointer
nm_conference_get_data(NMConference * conference)
{
if (conference == NULL)
return NULL;
return conference->data;
}
const char *
nm_conference_get_guid(NMConference * conference)
{
if (conference == NULL)
return NULL;
return conference->guid;
}