HGKeeper

Fix a crash on shutdown in kwallet if the wallet was never opened.

2021-03-23, Gary Kramlich

a6a5e36ddfe5

Fix a crash on shutdown in kwallet if the wallet was never opened.

The wallet instance variable was not initialized so if the wallet was never opened we were trying to delete and invalid pointer.

Also update the dispose method of the provider to close the wallet as the
tasks in the queue hold a reference to the provider instance as the source
object in their tasks.

Testing Done:
Ran locally with both the kwallet and secret service providers.

Reviewed at https://reviews.imfreedom.org/r/581/

<?xml version='1.0' encoding="ISO-8859-1"?>

<!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"

"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd" [

<title>Log signals</title>

<title role="signal_proto.title">List of signals</title>

"<link linkend="logs-log-timestamp">log-timestamp</link>"

</synopsis>

</refsect1>

<title role="signals.title">Signal details</title>

<title>The <literal>"log-timestamp"</literal> signal</title>

char * user_function (PurpleLog *log,

time_t when,

gboolean show_date,

gpointer user_data)

</programlisting>

<para>

Emitted to allow plugins to customize the timestamp on a message being logged.

</para>

Plugins must be careful of logs with a type of PURPLE_LOG_SYSTEM.

</para></note>

<listitem><simpara>The log the message belongs to.</simpara></listitem>

</varlistentry>

<listitem><simpara>The time to be converted to a string.</simpara></listitem>

</varlistentry>

<listitem><simpara>Whether the date should be displayed.</simpara></listitem>

</varlistentry>

<listitem><simpara>user data set when the signal handler was connected.</simpara></listitem>

</varlistentry>

<term><emphasis>Returns</emphasis> :</term>

<listitem><simpara>A textual representation of the time, or <literal>NULL</literal> to use a default format.</simpara></listitem>

</varlistentry>

</variablelist>

</refsect2>

</refsect1>

</chapter>

pidgin/pidgin