HGKeeper

Fix a crash on shutdown in kwallet if the wallet was never opened.

2021-03-23, Gary Kramlich

a6a5e36ddfe5

Fix a crash on shutdown in kwallet if the wallet was never opened.

The wallet instance variable was not initialized so if the wallet was never opened we were trying to delete and invalid pointer.

Also update the dispose method of the provider to close the wallet as the
tasks in the queue hold a reference to the provider instance as the source
object in their tasks.

Testing Done:
Ran locally with both the kwallet and secret service providers.

Reviewed at https://reviews.imfreedom.org/r/581/

<?xml version='1.0' encoding="ISO-8859-1"?>

<!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"

"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd" [

<title>Core signals</title>

<title role="signal_proto.title">List of signals</title>

"<link linkend="core-quitting">quitting</link>"

"<link linkend="core-uri-handler">uri-handler</link>"

</synopsis>

</refsect1>

<title role="signals.title">Signal details</title>

<title>The <literal>"quitting"</literal> signal</title>

void user_function (gpointer user_data)

</programlisting>

<para>

Emitted when libpurple is quitting.

</para>

<listitem><simpara>user data set when the signal handler was connected.</simpara></listitem>

</varlistentry>

</variablelist>

</refsect2>

<title>The <literal>"uri-handler"</literal> signal</title>

gboolean user_function (const gchar *proto,

const gchar *cmd,

GHashTable *params,

gpointer user_data)

</programlisting>

<para>

Emitted when handling a registered URI.

</para>

<term><parameter>proto</parameter> :</term>

<listitem><simpara>The protocol of the URI.</simpara></listitem>

</varlistentry>

<listitem><simpara>The 'command' of the URI.</simpara></listitem>

</varlistentry>

<term><parameter>params</parameter> :</term>

<listitem><simpara>Any key/value parameters from the URI.</simpara></listitem>

</varlistentry>

<listitem><simpara>user data set when the signal handler was connected.</simpara></listitem>

</varlistentry>

</variablelist>

</refsect2>

</refsect1>

</chapter>

pidgin/pidgin