HGKeeper

Fix a crash on shutdown in kwallet if the wallet was never opened.

2021-03-23, Gary Kramlich

a6a5e36ddfe5

Fix a crash on shutdown in kwallet if the wallet was never opened.

The wallet instance variable was not initialized so if the wallet was never opened we were trying to delete and invalid pointer.

Also update the dispose method of the provider to close the wallet as the
tasks in the queue hold a reference to the provider instance as the source
object in their tasks.

Testing Done:
Ran locally with both the kwallet and secret service providers.

Reviewed at https://reviews.imfreedom.org/r/581/

<?xml version='1.0' encoding="ISO-8859-1"?>

<!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"

"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd" [

<title>Certificate signals</title>

<title role="signal_proto.title">List of signals</title>

"<link linkend="certificates-certificate-stored">certificate-stored</link>"

"<link linkend="certificates-certificate-deleted">certificate-deleted</link>"

</synopsis>

</refsect1>

<title role="signals.title">Signal details</title>

<title>The <literal>"certificate-stored"</literal> signal</title>

void user_function (PurpleCertificatePool *pool,

const gchar *id,

gpointer data)

</programlisting>

<para>

Emitted when a pool stores a certificate. Connect to the pool instance.

</para>

<listitem><simpara>Pool the certificate has been stored into.</simpara></listitem>

</varlistentry>

<listitem><simpara>Key the certificate was stored under.</simpara></listitem>

</varlistentry>

</variablelist>

</refsect2>

<title>The <literal>"certificate-deleted"</literal> signal</title>

void user_function (PurpleCertificatePool *pool,

const gchar *id,

gpointer data)

</programlisting>

<para>

Emitted when a pool deletes a certificate. Connect to the pool instance.

</para>

<listitem><simpara>Pool the certificate was deleted from.</simpara></listitem>

</varlistentry>

<listitem><simpara>Key that was deleted.</simpara></listitem>

</varlistentry>

</variablelist>

</refsect2>

</refsect1>

</chapter>

pidgin/pidgin