pidgin/pidgin

Propagate the PurpleAccount::notify signal via PurpleAccountManager::account-changed

20 months ago, Gary Kramlich
a45d6db4f857
Propagate the PurpleAccount::notify signal via PurpleAccountManager::account-changed

This new signal supports details and works just like notify does on the account
instances, but it will be emitted for any account that the manager instance
knows about which means we can remove the old purple signals.

Testing Done:
Enabled and disabled accounts in Pidgin via the menus to make sure things were working right, and verified via the console that the accounts were being enabled and disabled.
Ran Finch, but I ran into the infinite loop bug in the buddy list clean when disabling an account which is a known issue.

Reviewed at https://reviews.imfreedom.org/r/2032/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <https://www.gnu.org/licenses/>.
*/
#include "purpleaddcontactrequest.h"
struct _PurpleAddContactRequest {
GObject parent;
PurpleAccount *account;
gchar *username;
gchar *alias;
gchar *message;
/* This tracks whether add has been called. */
gboolean handled;
};
enum {
SIG_ADD,
N_SIGNALS
};
static guint signals[N_SIGNALS] = {0, };
enum {
PROP_0,
PROP_ACCOUNT,
PROP_USERNAME,
PROP_ALIAS,
PROP_MESSAGE,
N_PROPERTIES,
};
static GParamSpec *properties[N_PROPERTIES] = {NULL, };
G_DEFINE_TYPE(PurpleAddContactRequest, purple_add_contact_request,
G_TYPE_OBJECT)
/******************************************************************************
* Helpers
*****************************************************************************/
static void
purple_add_contact_request_set_account(PurpleAddContactRequest *request,
PurpleAccount *account)
{
g_return_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request));
g_return_if_fail(PURPLE_IS_ACCOUNT(account));
if(g_set_object(&request->account, account)) {
g_object_notify_by_pspec(G_OBJECT(request), properties[PROP_ACCOUNT]);
}
}
static void
purple_add_contact_request_set_username(PurpleAddContactRequest *request,
const gchar *username)
{
g_return_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request));
g_free(request->username);
request->username = g_strdup(username);
g_object_notify_by_pspec(G_OBJECT(request), properties[PROP_USERNAME]);
}
/******************************************************************************
* GObject Implementation
*****************************************************************************/
static void
purple_add_contact_request_get_property(GObject *obj, guint param_id,
GValue *value, GParamSpec *pspec)
{
PurpleAddContactRequest *request = PURPLE_ADD_CONTACT_REQUEST(obj);
switch(param_id) {
case PROP_ACCOUNT:
g_value_set_object(value,
purple_add_contact_request_get_account(request));
break;
case PROP_USERNAME:
g_value_set_string(value,
purple_add_contact_request_get_username(request));
break;
case PROP_ALIAS:
g_value_set_string(value,
purple_add_contact_request_get_alias(request));
break;
case PROP_MESSAGE:
g_value_set_string(value,
purple_add_contact_request_get_message(request));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);
break;
}
}
static void
purple_add_contact_request_set_property(GObject *obj, guint param_id,
const GValue *value,
GParamSpec *pspec)
{
PurpleAddContactRequest *request = PURPLE_ADD_CONTACT_REQUEST(obj);
switch(param_id) {
case PROP_ACCOUNT:
purple_add_contact_request_set_account(request,
g_value_get_object(value));
break;
case PROP_USERNAME:
purple_add_contact_request_set_username(request,
g_value_get_string(value));
break;
case PROP_ALIAS:
purple_add_contact_request_set_alias(request,
g_value_get_string(value));
break;
case PROP_MESSAGE:
purple_add_contact_request_set_message(request,
g_value_get_string(value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);
break;
}
}
static void
purple_add_contact_request_dispose(GObject *obj) {
PurpleAddContactRequest *request = PURPLE_ADD_CONTACT_REQUEST(obj);
g_clear_object(&request->account);
G_OBJECT_CLASS(purple_add_contact_request_parent_class)->dispose(obj);
}
static void
purple_add_contact_request_finalize(GObject *obj) {
PurpleAddContactRequest *request = PURPLE_ADD_CONTACT_REQUEST(obj);
g_clear_pointer(&request->username, g_free);
g_clear_pointer(&request->alias, g_free);
g_clear_pointer(&request->message, g_free);
G_OBJECT_CLASS(purple_add_contact_request_parent_class)->finalize(obj);
}
static void
purple_add_contact_request_init(PurpleAddContactRequest *request) {
}
static void
purple_add_contact_request_class_init(PurpleAddContactRequestClass *klass)
{
GObjectClass *obj_class = G_OBJECT_CLASS(klass);
obj_class->get_property = purple_add_contact_request_get_property;
obj_class->set_property = purple_add_contact_request_set_property;
obj_class->dispose = purple_add_contact_request_dispose;
obj_class->finalize = purple_add_contact_request_finalize;
/**
* PurpleAddContactRequest::add:
* @request: The [class@AddContactRequest] instance.
*
* Emitted when the user has told the ui to add the contact. This is
* typically emitted by the user interface calling
* [method@AddContactRequest.add].
*
* Since: 3.0.0
*/
signals[SIG_ADD] = g_signal_new_class_handler(
"add",
G_OBJECT_CLASS_TYPE(klass),
G_SIGNAL_RUN_LAST,
NULL,
NULL,
NULL,
NULL,
G_TYPE_NONE,
0);
/**
* PurpleAddContactRequest:account:
*
* The account that this add contact request is for.
*
* Since: 3.0.0
*/
properties[PROP_ACCOUNT] = g_param_spec_object(
"account", "account",
"The account for this authorization request",
PURPLE_TYPE_ACCOUNT,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
/**
* PurpleAddContactRequest:username:
*
* The username of the remote user to be added.
*
* Since: 3.0.0
*/
properties[PROP_USERNAME] = g_param_spec_string(
"username", "username",
"The username of the remote user to be added.",
NULL,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
/**
* PurpleAddContactRequest:alias:
*
* The alias of the remote user to be added.
*
* Since: 3.0.0
*/
properties[PROP_ALIAS] = g_param_spec_string(
"alias", "alias",
"The alias of the remote user to be added.",
NULL,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
/**
* PurpleAddContactRequest:message:
*
* The optional message sent from the remote user.
*
* Since: 3.0.0
*/
properties[PROP_MESSAGE] = g_param_spec_string(
"message", "message",
"The optional message sent by the remote user",
NULL,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
g_object_class_install_properties(obj_class, N_PROPERTIES, properties);
}
/******************************************************************************
* Public API
*****************************************************************************/
PurpleAddContactRequest *
purple_add_contact_request_new(PurpleAccount *account, const gchar *username) {
g_return_val_if_fail(PURPLE_IS_ACCOUNT(account), NULL);
g_return_val_if_fail(username != NULL, NULL);
return g_object_new(
PURPLE_TYPE_ADD_CONTACT_REQUEST,
"account", account,
"username", username,
NULL);
}
PurpleAccount *
purple_add_contact_request_get_account(PurpleAddContactRequest *request) {
g_return_val_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request), NULL);
return request->account;
}
const gchar *
purple_add_contact_request_get_username(PurpleAddContactRequest *request) {
g_return_val_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request), NULL);
return request->username;
}
void
purple_add_contact_request_set_alias(PurpleAddContactRequest *request,
const gchar *alias)
{
g_return_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request));
g_free(request->alias);
request->alias = g_strdup(alias);
g_object_notify_by_pspec(G_OBJECT(request), properties[PROP_ALIAS]);
}
const gchar *
purple_add_contact_request_get_alias(PurpleAddContactRequest *request) {
g_return_val_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request), NULL);
return request->alias;
}
void
purple_add_contact_request_set_message(PurpleAddContactRequest *request,
const gchar *message)
{
g_return_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request));
g_free(request->message);
request->message = g_strdup(message);
g_object_notify_by_pspec(G_OBJECT(request), properties[PROP_MESSAGE]);
}
const gchar *
purple_add_contact_request_get_message(PurpleAddContactRequest *request) {
g_return_val_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request), NULL);
return request->message;
}
void
purple_add_contact_request_add(PurpleAddContactRequest *request) {
g_return_if_fail(PURPLE_IS_ADD_CONTACT_REQUEST(request));
/* Calling this multiple times is a programming error. */
g_return_if_fail(request->handled == FALSE);
request->handled = TRUE;
g_signal_emit(request, signals[SIG_ADD], 0);
}