pidgin/pidgin

Fix leaks in purple markup

14 months ago, Elliott Sales de Andrade
a39305511805
Fix leaks in purple markup

Fix leaks when running the markup tests. These are all from leaking `tags`:
```
24 bytes in 1 blocks are definitely lost in loss record 101 of 251
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48E563C: purple_markup_html_to_xhtml (purplemarkup.c:437)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401575: main (test_markup.c:281)

24 bytes in 1 blocks are definitely lost in loss record 102 of 251
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48E0319: purple_markup_html_to_xhtml (purplemarkup.c:260)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401575: main (test_markup.c:281)

24 bytes in 1 blocks are definitely lost in loss record 103 of 251
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48E07B7: purple_markup_html_to_xhtml (purplemarkup.c:261)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401575: main (test_markup.c:281)

24 bytes in 1 blocks are definitely lost in loss record 104 of 251
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48E0C55: purple_markup_html_to_xhtml (purplemarkup.c:262)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401575: main (test_markup.c:281)

24 bytes in 1 blocks are definitely lost in loss record 105 of 251
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48E10F3: purple_markup_html_to_xhtml (purplemarkup.c:263)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401575: main (test_markup.c:281)
```
and these from not freeing the result from `purple_unescape_html`:
```
256 bytes in 2 blocks are definitely lost in loss record 241 of 251
at 0x484378A: malloc (vg_replace_malloc.c:392)
by 0x484870B: realloc (vg_replace_malloc.c:1451)
by 0x49F771F: g_realloc (gmem.c:201)
by 0x4A11343: g_string_maybe_expand (gstring.c:92)
by 0x4A113BF: g_string_sized_new (gstring.c:116)
by 0x48E7F74: purple_unescape_html (purplemarkup.c:1101)
by 0x48DEBBA: purple_markup_html_to_xhtml (purplemarkup.c:224)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)

256 bytes in 2 blocks are definitely lost in loss record 242 of 251
at 0x484378A: malloc (vg_replace_malloc.c:392)
by 0x484870B: realloc (vg_replace_malloc.c:1451)
by 0x49F771F: g_realloc (gmem.c:201)
by 0x4A11343: g_string_maybe_expand (gstring.c:92)
by 0x4A113BF: g_string_sized_new (gstring.c:116)
by 0x48E7F74: purple_unescape_html (purplemarkup.c:1101)
by 0x48E534D: purple_markup_html_to_xhtml (purplemarkup.c:397)
by 0x401214: test_purple_markup_html_to_xhtml (test_markup.c:213)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
```

Also modified the test to check not passing the optional arguments.

Testing Done:
Compiled and ran tests in valgrind and leaks were gone.

Reviewed at https://reviews.imfreedom.org/r/2379/
/*
* Pidgin - Internet Messenger
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include <pidgin/pidginstatusprimitivechooser.h>
#include <pidgin/pidginiconname.h>
struct _PidginStatusPrimitiveChooser {
AdwBin parent;
GtkDropDown *chooser;
};
G_DEFINE_TYPE(PidginStatusPrimitiveChooser, pidgin_status_primitive_chooser,
ADW_TYPE_BIN)
/******************************************************************************
* Helpers
*****************************************************************************/
static PurpleStatusPrimitive
pidgin_status_primitive_chooser_primitive_from_string(const char *str) {
if(purple_strequal(str, "offline")) {
return PURPLE_STATUS_OFFLINE;
} else if(purple_strequal(str, "available")) {
return PURPLE_STATUS_AVAILABLE;
} else if(purple_strequal(str, "unavailable")) {
return PURPLE_STATUS_UNAVAILABLE;
} else if(purple_strequal(str, "invisible")) {
return PURPLE_STATUS_INVISIBLE;
} else if(purple_strequal(str, "away")) {
return PURPLE_STATUS_AWAY;
} else if(purple_strequal(str, "extended-away")) {
return PURPLE_STATUS_EXTENDED_AWAY;
}
return PURPLE_STATUS_UNSET;
}
/******************************************************************************
* Callbacks
*****************************************************************************/
static char *
pidgin_status_primitive_chooser_icon_name_cb(G_GNUC_UNUSED GObject *self,
GtkStringObject *object,
G_GNUC_UNUSED gpointer data)
{
PurpleStatusPrimitive primitive = PURPLE_STATUS_UNSET;
const char *value = NULL;
if(!GTK_IS_STRING_OBJECT(object)) {
return NULL;
}
value = gtk_string_object_get_string(object);
primitive = pidgin_status_primitive_chooser_primitive_from_string(value);
return g_strdup(pidgin_icon_name_from_status_primitive(primitive, NULL));
}
static char *
pidgin_status_primitive_chooser_label_cb(G_GNUC_UNUSED GObject *self,
GtkStringObject *object,
G_GNUC_UNUSED gpointer data)
{
PurpleStatusPrimitive primitive = PURPLE_STATUS_UNSET;
const char *value = NULL;
if(!GTK_IS_STRING_OBJECT(object)) {
return NULL;
}
value = gtk_string_object_get_string(object);
primitive = pidgin_status_primitive_chooser_primitive_from_string(value);
return g_strdup(purple_primitive_get_name_from_type(primitive));
}
/******************************************************************************
* GObject Implementation
*****************************************************************************/
static void
pidgin_status_primitive_chooser_init(PidginStatusPrimitiveChooser *chooser) {
gtk_widget_init_template(GTK_WIDGET(chooser));
}
static void
pidgin_status_primitive_chooser_class_init(PidginStatusPrimitiveChooserClass *klass) {
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
/* Widget template */
gtk_widget_class_set_template_from_resource(
widget_class, "/im/pidgin/Pidgin3/statusprimitivechooser.ui");
gtk_widget_class_bind_template_child(widget_class,
PidginStatusPrimitiveChooser,
chooser);
gtk_widget_class_bind_template_callback(widget_class,
pidgin_status_primitive_chooser_icon_name_cb);
gtk_widget_class_bind_template_callback(widget_class,
pidgin_status_primitive_chooser_label_cb);
}
/******************************************************************************
* Public API
*****************************************************************************/
GtkWidget *
pidgin_status_primitive_chooser_new(void) {
return g_object_new(PIDGIN_TYPE_STATUS_PRIMITIVE_CHOOSER, NULL);
}
PurpleStatusPrimitive
pidgin_status_primitive_chooser_get_selected(PidginStatusPrimitiveChooser *chooser) {
GtkStringObject *selected = NULL;
const char *value = NULL;
g_return_val_if_fail(PIDGIN_IS_STATUS_PRIMITIVE_CHOOSER(chooser),
PURPLE_STATUS_UNSET);
selected = gtk_drop_down_get_selected_item(chooser->chooser);
value = gtk_string_object_get_string(selected);
return pidgin_status_primitive_chooser_primitive_from_string(value);
}
void
pidgin_status_primitive_chooser_set_selected(PidginStatusPrimitiveChooser *chooser,
PurpleStatusPrimitive primitive)
{
GListModel *model = NULL;
g_return_if_fail(PIDGIN_IS_STATUS_PRIMITIVE_CHOOSER(chooser));
model = gtk_drop_down_get_model(chooser->chooser);
for(guint i = 0; i < g_list_model_get_n_items(model); i++) {
PurpleStatusPrimitive candidate = PURPLE_STATUS_UNSET;
GtkStringObject *str = NULL;
const char *value = NULL;
str = g_list_model_get_item(model, i);
value = gtk_string_object_get_string(str);
candidate = pidgin_status_primitive_chooser_primitive_from_string(value);
g_clear_object(&str);
if(primitive == candidate) {
gtk_drop_down_set_selected(chooser->chooser, i);
}
}
}