pidgin/pidgin

Fix some broken unit tests

2021-01-02, Gary Kramlich
a0c11a532ee7
Fix some broken unit tests

* Output the account username instead of the display name in an error message
that causes the tests to fail because the account has no connection.
* Move all `g_assert_no_error` checks **BEFORE** we check the any other results
that we're checking. If we're not supposed to get an error and we have one,
that error helps us find the issue which therefore makes unit test failures
actionable instead of a message to debug.

Testing Done:
Compiled and made sure the tests pass.

Reviewed at https://reviews.imfreedom.org/r/326/
---
id: im.pidgin.Finch3
runtime: org.gnome.Platform
runtime-version: '3.36'
sdk: org.gnome.Sdk
command: finch3
finish-args:
- --share=ipc
- --socket=x11
- --share=network
- --talk-name=org.freedesktop.Notifications
- --system-talk-name=org.freedesktop.Avahi
modules:
- packaging/flatpak/libpurple-common.yml
- packaging/flatpak/libgnt.yml
- name: finch3
buildsystem: meson
config-opts:
- -Dgtkui=false
- -Ddoc=false
sources:
- type: dir
path: '.'