pidgin/pidgin

Stop automatically adding/remove conversations from the conversation manager

7 weeks ago, Gary Kramlich
8019945e1c21
Stop automatically adding/remove conversations from the conversation manager

This was done to mimic the old conversations API and shouldn't be needed going
forward. However, since we can't create conversations right now, we're probably
missing some edge cases here.

Also make sure to keep a reference around on the conversation while removing to avoid use after frees.

Testing Done:
Trained with the turtles.

Reviewed at https://reviews.imfreedom.org/r/3049/
[constants]
macosx_sdk = '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk'
macosx_minver = '10.13'
common_args = ['--sysroot=' + macosx_sdk, '-mmacosx-version-min=' + macosx_minver, '-F' + macosx_sdk / 'System/Library/Frameworks']
homebrew_prefix = '/usr/local'
icu4c_pc = homebrew_prefix / 'opt/icu4c/lib/pkgconfig'
libsoup3_pc = homebrew_prefix / 'opt/libsoup@3/lib/pkgconfig'
libxml2_pc = homebrew_prefix / 'opt/libxml2/lib/pkgconfig'
python3_pc = homebrew_prefix / 'opt/python@3/lib/pkgconfig'
[built-in options]
c_args = common_args
c_link_args = common_args
cpp_args = common_args
cpp_link_args = common_args
objc_args = common_args
objc_link_args = common_args
objcpp_args = common_args
objcpp_link_args = common_args
pkg_config_path = [icu4c_pc, libsoup3_pc, libxml2_pc, python3_pc]
[project options]
introspection = false
[birb:project options]
doc = false
[gplugin:project options]
doc = false
introspection = false
lua = false
python3 = false
vapi = false
[binaries]
xgettext = homebrew_prefix / 'opt/gettext/bin/xgettext'