pidgin/pidgin

Stop automatically adding/remove conversations from the conversation manager

7 weeks ago, Gary Kramlich
8019945e1c21
Stop automatically adding/remove conversations from the conversation manager

This was done to mimic the old conversations API and shouldn't be needed going
forward. However, since we can't create conversations right now, we're probably
missing some edge cases here.

Also make sure to keep a reference around on the conversation while removing to avoid use after frees.

Testing Done:
Trained with the turtles.

Reviewed at https://reviews.imfreedom.org/r/3049/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This library is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the Free
* Software Foundation; either version 2 of the License, or (at your option)
* any later version.
*
* This library is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
* You should have received a copy of the GNU General Public License along with
* this library; if not, see <https://www.gnu.org/licenses/>.
*/
#include <glib/gi18n-lib.h>
#include "purplenoopcredentialprovider.h"
#include "purplecredentialmanager.h"
struct _PurpleNoopCredentialProvider {
PurpleCredentialProvider parent;
};
G_DEFINE_FINAL_TYPE(PurpleNoopCredentialProvider,
purple_noop_credential_provider,
PURPLE_TYPE_CREDENTIAL_PROVIDER)
/******************************************************************************
* PurpleCredentialProvider Implementation
*****************************************************************************/
static void
purple_noop_credential_provider_read_password_async(PurpleCredentialProvider *provider,
G_GNUC_UNUSED PurpleAccount *account,
GCancellable *cancellable,
GAsyncReadyCallback callback,
gpointer data)
{
GTask *task = NULL;
task = g_task_new(provider, cancellable, callback, data);
g_task_set_source_tag(task,
purple_noop_credential_provider_read_password_async);
g_task_return_new_error(task, PURPLE_CREDENTIAL_MANAGER_DOMAIN, 0,
_("provider does not store passwords"));
g_object_unref(task);
}
static gchar *
purple_noop_credential_provider_read_password_finish(G_GNUC_UNUSED PurpleCredentialProvider *provider,
GAsyncResult *result,
GError **error)
{
return g_task_propagate_pointer(G_TASK(result), error);
}
static void
purple_noop_credential_provider_write_password_async(PurpleCredentialProvider *provider,
G_GNUC_UNUSED PurpleAccount *account,
G_GNUC_UNUSED const char *password,
GCancellable *cancellable,
GAsyncReadyCallback callback,
gpointer data)
{
GTask *task = NULL;
task = g_task_new(provider, cancellable, callback, data);
g_task_set_source_tag(task,
purple_noop_credential_provider_write_password_async);
g_task_return_new_error(task, PURPLE_CREDENTIAL_MANAGER_DOMAIN, 0,
_("provider does not store passwords"));
g_object_unref(task);
}
static gboolean
purple_noop_credential_provider_write_password_finish(G_GNUC_UNUSED PurpleCredentialProvider *provider,
GAsyncResult *result,
GError **error)
{
return g_task_propagate_boolean(G_TASK(result), error);
}
/******************************************************************************
* GObject Implementation
*****************************************************************************/
static void
purple_noop_credential_provider_init(G_GNUC_UNUSED PurpleNoopCredentialProvider *provider)
{
}
static void
purple_noop_credential_provider_class_init(PurpleNoopCredentialProviderClass *klass)
{
PurpleCredentialProviderClass *provider_class = NULL;
provider_class = PURPLE_CREDENTIAL_PROVIDER_CLASS(klass);
provider_class->read_password_async =
purple_noop_credential_provider_read_password_async;
provider_class->read_password_finish =
purple_noop_credential_provider_read_password_finish;
provider_class->write_password_async =
purple_noop_credential_provider_write_password_async;
provider_class->write_password_finish =
purple_noop_credential_provider_write_password_finish;
}
/******************************************************************************
* Public API
*****************************************************************************/
PurpleCredentialProvider *
purple_noop_credential_provider_new(void) {
return g_object_new(
PURPLE_TYPE_NOOP_CREDENTIAL_PROVIDER,
"id", "noop-provider",
"name", _("None"),
"description", _("Passwords will not be saved."),
NULL);
}