pidgin/pidgin

Revert my previous change.

2017-01-08, Mark Doliner
7ccb54f5d342
Revert my previous change.

Apparently it caused `make distcheck` to fail which caused a Bitbucket build pipeline to fail: https://bitbucket.org/pidgin/main/addon/pipelines/home#!/results/%7B9f059724-78b4-4a5e-9780-9a614c7c2742%7D

Not sure how to fix this.

FYI there's a daily cronjob on... rock? in that calls /srv/trac/developer.pidgin.im/mercurial_support/nightly_update.sh which updates https://developer.pidgin.im/l10n/ It's been failing for a few months.
/**
* @file command.c MSN command functions
*
* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "internal.h"
#include "command.h"
static gboolean
is_num(const char *str)
{
const char *c;
for (c = str; *c; c++) {
if (!(g_ascii_isdigit(*c)))
return FALSE;
}
return TRUE;
}
MsnCommand *
msn_command_from_string(const char *string)
{
MsnCommand *cmd;
char *param_start;
g_return_val_if_fail(string != NULL, NULL);
cmd = g_new0(MsnCommand, 1);
cmd->command = g_strdup(string);
param_start = strchr(cmd->command, ' ');
if (param_start)
{
*param_start++ = '\0';
cmd->params = g_strsplit_set(param_start, " ", 0);
}
if (cmd->params != NULL)
{
guint c;
for (c = 0; cmd->params[c] && cmd->params[c][0]; c++);
cmd->param_count = c;
if (cmd->param_count) {
char *param = cmd->params[0];
cmd->trId = is_num(param) ? atoi(param) : 0;
} else {
cmd->trId = 0;
}
}
else
{
cmd->trId = 0;
}
msn_command_ref(cmd);
return cmd;
}
static void
msn_command_destroy(MsnCommand *cmd)
{
g_free(cmd->payload);
g_free(cmd->command);
g_strfreev(cmd->params);
g_free(cmd);
}
MsnCommand *
msn_command_ref(MsnCommand *cmd)
{
g_return_val_if_fail(cmd != NULL, NULL);
cmd->ref_count++;
return cmd;
}
void
msn_command_unref(MsnCommand *cmd)
{
g_return_if_fail(cmd != NULL);
g_return_if_fail(cmd->ref_count > 0);
cmd->ref_count--;
if (cmd->ref_count == 0)
{
msn_command_destroy(cmd);
}
}