pidgin/pidgin

Greatly simplify the nick color generation and properly detect dark themes.

2021-01-18, Gary Kramlich
766bbe6061ec
Greatly simplify the nick color generation and properly detect dark themes.

Instead of randomly adjusting colors based on some seed colors we now hash a user's name and use the first 2 bytes of the digest to determine the hue to color their nick. We then adjust it according to the background color.

This isn't perfect as you can see in the screen shot, but there are some tweaks we can do later to account for that. I skipped them for now as this gets us 90% of the way there with like 50% of the work.

Testing Done:
Compiled and ran locally with Adwaita, Adwaita-Dark, and Arc-Dark themes.

Bugs closed: PIDGIN-17463

Reviewed at https://reviews.imfreedom.org/r/423/
/*
* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*
*/
#include "protocol.h"
static GObjectClass *parent_class;
/**************************************************************************
* Protocol Object API
**************************************************************************/
const char *
purple_protocol_get_id(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), NULL);
return protocol->id;
}
const char *
purple_protocol_get_name(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), NULL);
return protocol->name;
}
PurpleProtocolOptions
purple_protocol_get_options(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), 0);
return protocol->options;
}
GList *
purple_protocol_get_user_splits(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), NULL);
return protocol->user_splits;
}
GList *
purple_protocol_get_account_options(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), NULL);
return protocol->account_options;
}
PurpleBuddyIconSpec *
purple_protocol_get_icon_spec(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), NULL);
return protocol->icon_spec;
}
PurpleWhiteboardOps *
purple_protocol_get_whiteboard_ops(const PurpleProtocol *protocol)
{
g_return_val_if_fail(PURPLE_IS_PROTOCOL(protocol), NULL);
return protocol->whiteboard_ops;
}
static void
icon_spec_free(PurpleProtocol *protocol)
{
g_return_if_fail(PURPLE_IS_PROTOCOL(protocol));
g_free(protocol->icon_spec);
protocol->icon_spec = NULL;
}
/**************************************************************************
* GObject stuff
**************************************************************************/
static void
purple_protocol_init(GTypeInstance *instance, gpointer klass)
{
}
static void
purple_protocol_finalize(GObject *object)
{
PurpleProtocol *protocol = PURPLE_PROTOCOL(object);
GList *accounts, *l;
accounts = purple_accounts_get_all_active();
for (l = accounts; l != NULL; l = l->next) {
PurpleAccount *account = PURPLE_ACCOUNT(l->data);
if (purple_account_is_disconnected(account))
continue;
if (purple_strequal(protocol->id,
purple_account_get_protocol_id(account)))
purple_account_disconnect(account);
}
g_list_free(accounts);
purple_request_close_with_handle(protocol);
purple_notify_close_with_handle(protocol);
purple_signals_disconnect_by_handle(protocol);
purple_signals_unregister_by_instance(protocol);
purple_prefs_disconnect_by_handle(protocol);
g_list_free_full(protocol->user_splits, (GDestroyNotify)purple_account_user_split_destroy);
g_list_free_full(protocol->account_options, (GDestroyNotify)purple_account_option_destroy);
icon_spec_free(protocol);
parent_class->finalize(object);
}
static void
purple_protocol_class_init(PurpleProtocolClass *klass)
{
GObjectClass *obj_class = G_OBJECT_CLASS(klass);
parent_class = g_type_class_peek_parent(klass);
obj_class->finalize = purple_protocol_finalize;
}
GType
purple_protocol_get_type(void)
{
static GType type = 0;
if (G_UNLIKELY(type == 0)) {
static const GTypeInfo info = {
.class_size = sizeof(PurpleProtocolClass),
.class_init = (GClassInitFunc)purple_protocol_class_init,
.instance_size = sizeof(PurpleProtocol),
.instance_init = (GInstanceInitFunc)purple_protocol_init,
};
type = g_type_register_static(G_TYPE_OBJECT, "PurpleProtocol",
&info, G_TYPE_FLAG_ABSTRACT);
}
return type;
}
/**************************************************************************
* Protocol Class API
**************************************************************************/
#define DEFINE_PROTOCOL_FUNC(protocol,funcname,...) \
PurpleProtocolClass *klass = PURPLE_PROTOCOL_GET_CLASS(protocol); \
g_return_if_fail(klass != NULL); \
if (klass->funcname) \
klass->funcname(__VA_ARGS__);
#define DEFINE_PROTOCOL_FUNC_WITH_RETURN(protocol,defaultreturn,funcname,...) \
PurpleProtocolClass *klass = PURPLE_PROTOCOL_GET_CLASS(protocol); \
g_return_val_if_fail(klass != NULL, defaultreturn); \
if (klass->funcname) \
return klass->funcname(__VA_ARGS__); \
else \
return defaultreturn;
void
purple_protocol_class_login(PurpleProtocol *protocol, PurpleAccount *account)
{
DEFINE_PROTOCOL_FUNC(protocol, login, account);
}
void
purple_protocol_class_close(PurpleProtocol *protocol, PurpleConnection *gc)
{
DEFINE_PROTOCOL_FUNC(protocol, close, gc);
}
GList *
purple_protocol_class_status_types(PurpleProtocol *protocol,
PurpleAccount *account)
{
DEFINE_PROTOCOL_FUNC_WITH_RETURN(protocol, NULL, status_types, account);
}
const char *
purple_protocol_class_list_icon(PurpleProtocol *protocol,
PurpleAccount *account, PurpleBuddy *buddy)
{
DEFINE_PROTOCOL_FUNC_WITH_RETURN(protocol, NULL, list_icon, account, buddy);
}
#undef DEFINE_PROTOCOL_FUNC_WITH_RETURN
#undef DEFINE_PROTOCOL_FUNC