pidgin/pidgin

Try to fix some gwarnings when pidgin_blist_update_sort_method gets called before the menu of the buddy list exists. This is pretty crappy, but this just helps me get through gdb faster right now.

2020-09-07, Gary Kramlich
5fca0fffc9c3
Try to fix some gwarnings when pidgin_blist_update_sort_method gets called before the menu of the buddy list exists. This is pretty crappy, but this just helps me get through gdb faster right now.

There are some conditions where pidgin_blist_update_sort_methods will get called before the menu widget exists.

Testing Done:
Compiled and ran in gdb with `G_DEBUG=fatal-warnings`.

Reviewed at https://reviews.imfreedom.org/r/101/
/* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "pidgininvitedialog.h"
#include "pidgincontactcompletion.h"
struct _PidginInviteDialog {
GtkDialog parent;
};
typedef struct {
GtkWidget *contact;
GtkWidget *message;
PurpleChatConversation *conversation;
} PidginInviteDialogPrivate;
enum {
PROP_ZERO,
PROP_CONTACT,
PROP_MESSAGE,
PROP_CONVERSATION,
N_PROPERTIES,
};
static GParamSpec *properties[N_PROPERTIES] = {0, };
G_DEFINE_TYPE_WITH_PRIVATE(PidginInviteDialog, pidgin_invite_dialog, GTK_TYPE_DIALOG);
/******************************************************************************
* Helpers
*****************************************************************************/
static void
pidgin_invite_dialog_set_conversation(PidginInviteDialog *dialog,
PurpleChatConversation *conversation)
{
PidginInviteDialogPrivate *priv = NULL;
g_return_if_fail(PIDGIN_IS_INVITE_DIALOG(dialog));
priv = pidgin_invite_dialog_get_instance_private(dialog);
priv->conversation = g_object_ref(conversation);
g_object_notify_by_pspec(G_OBJECT(dialog), properties[PROP_CONVERSATION]);
}
/******************************************************************************
* GObject Stuff
*****************************************************************************/
static void
pidgin_invite_dialog_get_property(GObject *obj,
guint param_id,
GValue *value,
GParamSpec *pspec)
{
PidginInviteDialog *dialog = PIDGIN_INVITE_DIALOG(obj);
switch(param_id) {
case PROP_CONTACT:
g_value_set_string(value,
pidgin_invite_dialog_get_contact(dialog));
break;
case PROP_MESSAGE:
g_value_set_string(value,
pidgin_invite_dialog_get_message(dialog));
break;
case PROP_CONVERSATION:
g_value_set_object(value,
pidgin_invite_dialog_get_conversation(dialog));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);
break;
}
}
static void
pidgin_invite_dialog_set_property(GObject *obj,
guint param_id,
const GValue *value,
GParamSpec *pspec)
{
PidginInviteDialog *dialog = PIDGIN_INVITE_DIALOG(obj);
switch(param_id) {
case PROP_CONTACT:
pidgin_invite_dialog_set_contact(dialog,
g_value_get_string(value));
break;
case PROP_MESSAGE:
pidgin_invite_dialog_set_message(dialog,
g_value_get_string(value));
break;
case PROP_CONVERSATION:
pidgin_invite_dialog_set_conversation(dialog,
g_value_get_object(value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);
break;
}
}
static void
pidgin_invite_dialog_finalize(GObject *obj) {
PidginInviteDialogPrivate *priv = NULL;
priv = pidgin_invite_dialog_get_instance_private(PIDGIN_INVITE_DIALOG(obj));
g_clear_pointer(&priv->contact, g_free);
g_clear_pointer(&priv->message, g_free);
g_clear_object(&priv->conversation);
G_OBJECT_CLASS(pidgin_invite_dialog_parent_class)->finalize(obj);
}
static void
pidgin_invite_dialog_init(PidginInviteDialog *dialog) {
gtk_widget_init_template(GTK_WIDGET(dialog));
}
static void
pidgin_invite_dialog_constructed(GObject *obj) {
PidginInviteDialog *dialog = PIDGIN_INVITE_DIALOG(obj);
PidginInviteDialogPrivate *priv = NULL;
GtkEntryCompletion *completion = NULL;
priv = pidgin_invite_dialog_get_instance_private(dialog);
completion = pidgin_contact_completion_new();
/* constructed is called after all properties are set, so we set the
* account for the completion from the conversation we were created with.
*/
if(priv->conversation) {
PurpleAccount *account = purple_conversation_get_account(PURPLE_CONVERSATION(priv->conversation));
if(account != NULL) {
pidgin_contact_completion_set_account(
PIDGIN_CONTACT_COMPLETION(completion),
account
);
}
}
gtk_entry_set_completion(GTK_ENTRY(priv->contact), completion);
g_object_unref(completion);
}
static void
pidgin_invite_dialog_class_init(PidginInviteDialogClass *klass) {
GObjectClass *obj_class = G_OBJECT_CLASS(klass);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
obj_class->get_property = pidgin_invite_dialog_get_property;
obj_class->set_property = pidgin_invite_dialog_set_property;
obj_class->finalize = pidgin_invite_dialog_finalize;
obj_class->constructed = pidgin_invite_dialog_constructed;
gtk_widget_class_set_template_from_resource(
widget_class,
"/im/pidgin/Pidgin/Conversations/invite_dialog.ui"
);
gtk_widget_class_bind_template_child_private(
widget_class,
PidginInviteDialog,
contact
);
gtk_widget_class_bind_template_child_private(
widget_class,
PidginInviteDialog,
message
);
properties[PROP_CONTACT] = g_param_spec_string(
"contact",
"contact",
"The person that is being invited",
NULL,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
properties[PROP_MESSAGE] = g_param_spec_string(
"message",
"message",
"The invite message to send",
NULL,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
properties[PROP_CONVERSATION] = g_param_spec_object(
"conversation",
"conversation",
"The conversation that someone is being invited to",
PURPLE_TYPE_CHAT_CONVERSATION,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY);
g_object_class_install_properties(obj_class, N_PROPERTIES, properties);
}
/******************************************************************************
* Public API
*****************************************************************************/
GtkWidget *
pidgin_invite_dialog_new(PurpleChatConversation *conversation) {
return GTK_WIDGET(g_object_new(
PIDGIN_TYPE_INVITE_DIALOG,
"conversation", conversation,
NULL));
}
const gchar *
pidgin_invite_dialog_get_contact(PidginInviteDialog *dialog) {
PidginInviteDialogPrivate *priv = NULL;
g_return_val_if_fail(PIDGIN_IS_INVITE_DIALOG(dialog), NULL);
priv = pidgin_invite_dialog_get_instance_private(dialog);
return gtk_entry_get_text(GTK_ENTRY(priv->contact));
}
void
pidgin_invite_dialog_set_contact(PidginInviteDialog *dialog,
const gchar *contact)
{
PidginInviteDialogPrivate *priv = NULL;
g_return_if_fail(PIDGIN_IS_INVITE_DIALOG(dialog));
priv = pidgin_invite_dialog_get_instance_private(dialog);
if(contact != NULL) {
gtk_entry_set_text(GTK_ENTRY(priv->contact), contact);
g_object_notify_by_pspec(G_OBJECT(dialog), properties[PROP_CONTACT]);
}
}
const gchar *
pidgin_invite_dialog_get_message(PidginInviteDialog *dialog) {
PidginInviteDialogPrivate *priv = NULL;
g_return_val_if_fail(PIDGIN_IS_INVITE_DIALOG(dialog), NULL);
priv = pidgin_invite_dialog_get_instance_private(dialog);
return gtk_entry_get_text(GTK_ENTRY(priv->message));
}
void
pidgin_invite_dialog_set_message(PidginInviteDialog *dialog,
const gchar *message)
{
PidginInviteDialogPrivate *priv = NULL;
g_return_if_fail(PIDGIN_IS_INVITE_DIALOG(dialog));
priv = pidgin_invite_dialog_get_instance_private(dialog);
if(message != NULL) {
gtk_entry_set_text(GTK_ENTRY(priv->message), message);
g_object_notify_by_pspec(G_OBJECT(dialog), properties[PROP_MESSAGE]);
}
}
PurpleChatConversation *
pidgin_invite_dialog_get_conversation(PidginInviteDialog *dialog) {
PidginInviteDialogPrivate *priv = NULL;
g_return_val_if_fail(PIDGIN_IS_INVITE_DIALOG(dialog), NULL);
priv = pidgin_invite_dialog_get_instance_private(dialog);
return priv->conversation;
}