pidgin/pidgin

Fix several leaks in tests

14 months ago, Elliott Sales de Andrade
4e1bf25f5575
Fix several leaks in tests

All of these are specific to tests, not the library code.

For the moment, `protocol_xfer` still leaks connections (and anything they hold on to) because it is very difficult to disentangle them from the connection manager in the partially implemented state they are in.

This fixes leaks of options in the account option test (these two leaks occur for every test since they all leak the option):
```
61 (48 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 133 of 276
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48C3B2E: purple_account_option_new (purpleaccountoption.c:78)
by 0x4014AF: test_purple_account_option_copy_int (test_account_option.c:67)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401721: main (test_account_option.c:157)

61 (48 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 134 of 276
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48C3BC7: purple_account_option_copy (purpleaccountoption.c:93)
by 0x4014BF: test_purple_account_option_copy_int (test_account_option.c:68)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401721: main (test_account_option.c:157)
```
leaks in the credential manager test (times 3 for read/write/cancel tests):
```
69 (16 direct, 53 indirect) bytes in 1 blocks are definitely lost in loss record 2,427 of 3,503
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4A58168: g_malloc (gmem.c:130)
by 0x4A6FAB5: g_slice_alloc (gslice.c:1074)
by 0x4A700EC: g_slice_alloc0 (gslice.c:1100)
by 0x4A3BECB: g_error_allocate (gerror.c:710)
by 0x4A3C93F: UnknownInlinedFun (gerror.c:724)
by 0x4A3C93F: g_error_new_valist (gerror.c:766)
by 0x4BEE558: g_task_return_new_error (gtask.c:1941)
by 0x48D82C0: purple_credential_manager_read_password_async (purplecredentialmanager.c:492)
by 0x403634: test_purple_credential_manager_no_provider_read_password_idle (test_credential_manager.c:329)
by 0x4A4ECB1: g_idle_dispatch (gmain.c:6124)
by 0x4A4FCBE: UnknownInlinedFun (gmain.c:3444)
by 0x4A4FCBE: g_main_context_dispatch (gmain.c:4162)
by 0x4AA5597: g_main_context_iterate.constprop.0 (gmain.c:4238)
by 0x4A4F28E: g_main_loop_run (gmain.c:4438)
by 0x40369F: test_purple_credential_manager_no_provider_read_password_async (test_credential_manager.c:345)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x4048F6: main (test_credential_manager.c:695)
```
a leak in the image test:
```
161 bytes in 1 blocks are definitely lost in loss record 260 of 274
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4A55363: g_try_malloc (gmem.c:286)
by 0x4A3D630: UnknownInlinedFun (gfileutils.c:819)
by 0x4A3D630: UnknownInlinedFun (gfileutils.c:924)
by 0x4A3D630: g_file_get_contents (gfileutils.c:1027)
by 0x401890: test_image_new_from_file (test_image.c:144)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x40195D: main (test_image.c:172)
```
a leak in queued output stream test:
```
72 (40 direct, 32 indirect) bytes in 1 blocks are definitely lost in loss record 219 of 396
at 0x49D51EF: g_type_create_instance (gtype.c:1909)
by 0x49BAC1F: g_object_new_internal (gobject.c:2228)
by 0x49BC247: g_object_new_with_properties (gobject.c:2391)
by 0x49BCFF0: g_object_new (gobject.c:2037)
by 0x402003: test_queued_output_stream_push_bytes_async_error (test_queued_output_stream.c:219)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x402429: main (test_queued_output_stream.c:280)
```
and protocol xfer tests (times 3 for each test that creates a test protocol object):
```
112 (48 direct, 64 indirect) bytes in 1 blocks are definitely lost in loss record 3,430 of 3,698
at 0x49D51EF: g_type_create_instance (gtype.c:1909)
by 0x49BAC1F: g_object_new_internal (gobject.c:2228)
by 0x49BC247: g_object_new_with_properties (gobject.c:2391)
by 0x49BCFF0: g_object_new (gobject.c:2037)
by 0x40291C: test_purple_protocol_xfer_send_file_func (test_protocol_xfer.c:146)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x402B64: main (test_protocol_xfer.c:195)
```
and util tests (times 3 for each call to `purple_text_strip_mnemonic` in the test):
```
5 bytes in 1 blocks are definitely lost in loss record 5 of 247
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x49F7168: g_malloc (gmem.c:130)
by 0x491975B: purple_text_strip_mnemonic (util.c:895)
by 0x4015B0: test_util_text_strip_mnemonic (test_util.c:49)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401901: main (test_util.c:224)
```
and these leaks in any test that initializes the test UI:
```
4,104 bytes in 1 blocks are possibly lost in loss record 3,451 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5249A8B: UnknownInlinedFun (sqlite3.c:53675)
by 0x5249A8B: allocateTempSpace (sqlite3.c:70848)
by 0x52625A6: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:93857)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x529B324: sqlite3_exec (sqlite3.c:131002)
by 0x48FD558: purple_sqlite3_run_migration (purplesqlite3.c:37)
by 0x48FDBB4: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:195)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)

4,368 bytes in 1 blocks are possibly lost in loss record 3,453 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5240077: UnknownInlinedFun (sqlite3.c:53634)
by 0x5240077: pcache1FetchStage2 (sqlite3.c:54104)
by 0x5243E9C: UnknownInlinedFun (sqlite3.c:52671)
by 0x5243E9C: getPageNormal.lto_priv.0 (sqlite3.c:60628)
by 0x524A510: UnknownInlinedFun (sqlite3.c:60805)
by 0x524A510: btreeGetPage.lto_priv.0 (sqlite3.c:70289)
by 0x524C2F6: UnknownInlinedFun (sqlite3.c:71257)
by 0x524C2F6: sqlite3BtreeBeginTrans.lto_priv.0 (sqlite3.c:71647)
by 0x5266B3A: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:93532)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x48FD715: purple_sqlite3_get_schema_version (purplesqlite3.c:79)
by 0x48FD9DD: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:146)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)

4,368 bytes in 1 blocks are possibly lost in loss record 3,454 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5240077: UnknownInlinedFun (sqlite3.c:53634)
by 0x5240077: pcache1FetchStage2 (sqlite3.c:54104)
by 0x5243E9C: UnknownInlinedFun (sqlite3.c:52671)
by 0x5243E9C: getPageNormal.lto_priv.0 (sqlite3.c:60628)
by 0x52499BC: UnknownInlinedFun (sqlite3.c:60805)
by 0x52499BC: UnknownInlinedFun (sqlite3.c:70289)
by 0x52499BC: btreeGetUnusedPage (sqlite3.c:70432)
by 0x524F504: allocateBtreePage.lto_priv.0 (sqlite3.c:74604)
by 0x5256209: btreeCreateTable.lto_priv.0 (sqlite3.c:77830)
by 0x5265EB2: UnknownInlinedFun (sqlite3.c:77849)
by 0x5265EB2: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:96382)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x529B324: sqlite3_exec (sqlite3.c:131002)
by 0x48FD558: purple_sqlite3_run_migration (purplesqlite3.c:37)
by 0x48FDBB4: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:195)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)
```

Testing Done:
Ran tests in valgrind, and all above leaks were gone except for noted `protocol_xfer` issues, and a bunch of leaks of the `PurpleBuddy`-`PurpleContact` compatibility bindings, which will go away in their entirety eventually.

Reviewed at https://reviews.imfreedom.org/r/2385/
/*
* Pidgin - Internet Messenger
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#ifdef HAVE_CONFIG_H
# include <config.h>
#endif
#include <errno.h>
#include <math.h>
#include <glib/gi18n-lib.h>
#include <glib/gstdio.h>
#include <purple.h>
#include "pidginprefs.h"
#include "pidginprefsinternal.h"
#include "gtkutils.h"
#include "pidgincore.h"
#include "pidginvvprefs.h"
struct _PidginPrefsWindow {
GtkDialog parent;
};
G_DEFINE_TYPE(PidginPrefsWindow, pidgin_prefs_window, GTK_TYPE_DIALOG);
/******************************************************************************
* Helpers
*****************************************************************************/
static void
update_spin_value(G_GNUC_UNUSED GtkWidget *w, GtkWidget *spin)
{
const char *key = g_object_get_data(G_OBJECT(spin), "val");
int value;
value = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(spin));
purple_prefs_set_int(key, value);
}
GtkWidget *
pidgin_prefs_labeled_spin_button(GtkWidget *box, const gchar *title,
const char *key, int min, int max, GtkSizeGroup *sg)
{
GtkWidget *spin;
GtkAdjustment *adjust;
int val;
val = purple_prefs_get_int(key);
adjust = GTK_ADJUSTMENT(gtk_adjustment_new(val, min, max, 1, 1, 0));
spin = gtk_spin_button_new(adjust, 1, 0);
g_object_set_data(G_OBJECT(spin), "val", (char *)key);
if (max < 10000)
gtk_widget_set_size_request(spin, 50, -1);
else
gtk_widget_set_size_request(spin, 60, -1);
g_signal_connect(G_OBJECT(adjust), "value-changed",
G_CALLBACK(update_spin_value), GTK_WIDGET(spin));
return pidgin_add_widget_to_vbox(GTK_BOX(box), title, sg, spin, FALSE, NULL);
}
void
pidgin_prefs_bind_spin_button(const char *key, GtkWidget *spin)
{
GtkAdjustment *adjust;
int val;
val = purple_prefs_get_int(key);
adjust = gtk_spin_button_get_adjustment(GTK_SPIN_BUTTON(spin));
gtk_adjustment_set_value(adjust, val);
g_object_set_data(G_OBJECT(spin), "val", (char *)key);
g_signal_connect(G_OBJECT(adjust), "value-changed",
G_CALLBACK(update_spin_value), GTK_WIDGET(spin));
}
static void
entry_set(GtkEntry *entry, gpointer data)
{
const char *key = (const char*)data;
purple_prefs_set_string(key, gtk_editable_get_text(GTK_EDITABLE(entry)));
}
void
pidgin_prefs_bind_entry(const char *key, GtkWidget *entry)
{
const gchar *value;
value = purple_prefs_get_string(key);
gtk_editable_set_text(GTK_EDITABLE(entry), value);
g_signal_connect(G_OBJECT(entry), "changed", G_CALLBACK(entry_set),
(char*)key);
}
static void
dropdown_set(GtkComboBox *combo_box, G_GNUC_UNUSED gpointer data)
{
GtkTreeIter iter;
GtkTreeModel *tree_model;
PurplePrefType type;
const char *key;
tree_model = gtk_combo_box_get_model(combo_box);
if (!gtk_combo_box_get_active_iter(combo_box, &iter)) {
return;
}
type = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(combo_box), "type"));
key = g_object_get_data(G_OBJECT(combo_box), "key");
if (type == PURPLE_PREF_INT) {
gint value;
gtk_tree_model_get(tree_model, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
purple_prefs_set_int(key, value);
} else if (type == PURPLE_PREF_STRING) {
gchar *value;
gtk_tree_model_get(tree_model, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
purple_prefs_set_string(key, value);
g_free(value);
} else if (type == PURPLE_PREF_BOOLEAN) {
gboolean value;
gtk_tree_model_get(tree_model, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
purple_prefs_set_bool(key, value);
} else {
g_return_if_reached();
}
}
GtkWidget *
pidgin_prefs_dropdown_from_list(GtkWidget *box, const gchar *title,
PurplePrefType type, const char *key, GList *menuitems)
{
GtkWidget *dropdown = NULL;
GtkWidget *label = NULL;
GtkListStore *store = NULL;
GtkTreeIter active;
GtkCellRenderer *renderer;
gint pref_int_value = 0;
const gchar *pref_str_value = NULL;
gboolean pref_bool_value = FALSE;
g_return_val_if_fail(menuitems != NULL, NULL);
if (type == PURPLE_PREF_INT) {
pref_int_value = purple_prefs_get_int(key);
store = gtk_list_store_new(PIDGIN_PREF_COMBO_N_COLUMNS, G_TYPE_STRING,
G_TYPE_INT);
} else if (type == PURPLE_PREF_STRING) {
pref_str_value = purple_prefs_get_string(key);
store = gtk_list_store_new(PIDGIN_PREF_COMBO_N_COLUMNS, G_TYPE_STRING,
G_TYPE_STRING);
} else if (type == PURPLE_PREF_BOOLEAN) {
pref_bool_value = purple_prefs_get_bool(key);
store = gtk_list_store_new(PIDGIN_PREF_COMBO_N_COLUMNS, G_TYPE_STRING,
G_TYPE_BOOLEAN);
} else {
g_return_val_if_reached(NULL);
}
dropdown = gtk_combo_box_new_with_model(GTK_TREE_MODEL(store));
g_object_set_data(G_OBJECT(dropdown), "type", GINT_TO_POINTER(type));
for (; menuitems != NULL; menuitems = g_list_next(menuitems)) {
const PurpleKeyValuePair *menu_item = menuitems->data;
GtkTreeIter iter;
if (menu_item->key == NULL) {
break;
}
gtk_list_store_append(store, &iter);
gtk_list_store_set(store, &iter,
PIDGIN_PREF_COMBO_TEXT, menu_item->key,
-1);
if (type == PURPLE_PREF_INT) {
gint value = GPOINTER_TO_INT(menu_item->value);
gtk_list_store_set(store, &iter, PIDGIN_PREF_COMBO_VALUE, value, -1);
if (pref_int_value == value) {
active = iter;
}
} else if (type == PURPLE_PREF_STRING) {
const gchar *value = (const gchar *)menu_item->value;
gtk_list_store_set(store, &iter, PIDGIN_PREF_COMBO_VALUE, value, -1);
if (purple_strequal(pref_str_value, value)) {
active = iter;
}
} else if (type == PURPLE_PREF_BOOLEAN) {
gboolean value = (gboolean)GPOINTER_TO_INT(menu_item->value);
gtk_list_store_set(store, &iter, PIDGIN_PREF_COMBO_VALUE, value, -1);
if (pref_bool_value == value) {
active = iter;
}
}
}
renderer = gtk_cell_renderer_text_new();
gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(dropdown), renderer, TRUE);
gtk_cell_layout_set_attributes(GTK_CELL_LAYOUT(dropdown), renderer,
"text", 0,
NULL);
gtk_combo_box_set_active_iter(GTK_COMBO_BOX(dropdown), &active);
g_signal_connect(dropdown, "changed", G_CALLBACK(dropdown_set), NULL);
pidgin_add_widget_to_vbox(GTK_BOX(box), title, NULL, dropdown, FALSE, &label);
g_object_set_data(G_OBJECT(dropdown), "key", (gpointer)key);
return label;
}
GtkWidget *
pidgin_prefs_dropdown(GtkWidget *box, const gchar *title, PurplePrefType type,
const char *key, ...)
{
va_list ap;
GList *menuitems = NULL;
GtkWidget *dropdown = NULL;
char *name;
g_return_val_if_fail(type == PURPLE_PREF_BOOLEAN || type == PURPLE_PREF_INT ||
type == PURPLE_PREF_STRING, NULL);
va_start(ap, key);
while ((name = va_arg(ap, char *)) != NULL) {
PurpleKeyValuePair *kvp;
if (type == PURPLE_PREF_INT || type == PURPLE_PREF_BOOLEAN) {
kvp = purple_key_value_pair_new(name, GINT_TO_POINTER(va_arg(ap, int)));
} else {
kvp = purple_key_value_pair_new(name, va_arg(ap, char *));
}
menuitems = g_list_prepend(menuitems, kvp);
}
va_end(ap);
g_return_val_if_fail(menuitems != NULL, NULL);
menuitems = g_list_reverse(menuitems);
dropdown = pidgin_prefs_dropdown_from_list(box, title, type, key,
menuitems);
g_list_free_full(menuitems, (GDestroyNotify)purple_key_value_pair_free);
return dropdown;
}
static void
bind_dropdown_set(GtkComboBox *combo_box, gpointer data)
{
PidginPrefCombo *combo = data;
GtkTreeIter iter;
GtkTreeModel *tree_model;
tree_model = gtk_combo_box_get_model(combo_box);
if (!gtk_combo_box_get_active_iter(combo_box, &iter))
return;
if (combo->type == PURPLE_PREF_INT) {
gint value;
gtk_tree_model_get(tree_model, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
purple_prefs_set_int(combo->key, value);
} else if (combo->type == PURPLE_PREF_STRING) {
gchar *value;
gtk_tree_model_get(tree_model, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
purple_prefs_set_string(combo->key, value);
g_free(value);
} else if (combo->type == PURPLE_PREF_BOOLEAN) {
gboolean value;
gtk_tree_model_get(tree_model, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
purple_prefs_set_bool(combo->key, value);
} else {
g_return_if_reached();
}
}
void
pidgin_prefs_bind_dropdown(PidginPrefCombo *combo)
{
GtkTreeModel *store = NULL;
GtkTreeIter iter;
GtkTreeIter active;
int pref_int_value = 0;
const char *pref_str_value = NULL;
gboolean pref_bool_value = FALSE;
if (combo->type == PURPLE_PREF_INT) {
pref_int_value = purple_prefs_get_int(combo->key);
} else if (combo->type == PURPLE_PREF_STRING) {
pref_str_value = purple_prefs_get_string(combo->key);
} else if (combo->type == PURPLE_PREF_BOOLEAN) {
pref_bool_value = purple_prefs_get_bool(combo->key);
} else {
g_return_if_reached();
}
store = gtk_combo_box_get_model(GTK_COMBO_BOX(combo->combo));
if (!gtk_tree_model_get_iter_first(store, &iter)) {
g_return_if_reached();
}
do {
if (combo->type == PURPLE_PREF_INT) {
gint value = 0;
gtk_tree_model_get(store, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
if (pref_int_value == value) {
active = iter;
break;
}
} else if (combo->type == PURPLE_PREF_STRING) {
gchar *value = NULL;
gtk_tree_model_get(store, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
if (purple_strequal(pref_str_value, value)) {
active = iter;
g_free(value);
break;
}
g_free(value);
} else if (combo->type == PURPLE_PREF_BOOLEAN) {
gboolean value = FALSE;
gtk_tree_model_get(store, &iter, PIDGIN_PREF_COMBO_VALUE, &value, -1);
if (pref_bool_value == value) {
active = iter;
break;
}
}
} while (gtk_tree_model_iter_next(store, &iter));
gtk_combo_box_set_active_iter(GTK_COMBO_BOX(combo->combo), &active);
g_signal_connect(G_OBJECT(combo->combo), "changed",
G_CALLBACK(bind_dropdown_set), combo);
}
static void
bind_combo_row_set(GObject *obj, G_GNUC_UNUSED GParamSpec *pspec,
gpointer data)
{
const gchar *key = data;
GtkStringObject *item = NULL;
const gchar *value = NULL;
item = adw_combo_row_get_selected_item(ADW_COMBO_ROW(obj));
value = gtk_string_object_get_string(item);
purple_prefs_set_string(key, value);
}
void
pidgin_prefs_bind_combo_row(const gchar *key, GtkWidget *widget) {
GtkStringList *model = NULL;
const char *pref_value = NULL;
guint selected = GTK_INVALID_LIST_POSITION;
pref_value = purple_prefs_get_string(key);
model = GTK_STRING_LIST(adw_combo_row_get_model(ADW_COMBO_ROW(widget)));
for(guint i = 0; i < g_list_model_get_n_items(G_LIST_MODEL(model)); i++) {
const char *value = gtk_string_list_get_string(model, i);
if (purple_strequal(pref_value, value)) {
selected = i;
break;
}
}
adw_combo_row_set_selected(ADW_COMBO_ROW(widget), selected);
g_signal_connect(widget, "notify::selected",
G_CALLBACK(bind_combo_row_set), (gpointer)key);
}
static void
set_bool_pref(GtkWidget *w, const char *key)
{
purple_prefs_set_bool(key,
gtk_check_button_get_active(GTK_CHECK_BUTTON(w)));
}
GtkWidget *
pidgin_prefs_checkbox(const char *text, const char *key, GtkWidget *page)
{
GtkWidget *button;
button = gtk_check_button_new_with_mnemonic(text);
gtk_check_button_set_active(GTK_CHECK_BUTTON(button),
purple_prefs_get_bool(key));
gtk_box_append(GTK_BOX(page), button);
g_signal_connect(G_OBJECT(button), "clicked",
G_CALLBACK(set_bool_pref), (char *)key);
return button;
}
void
pidgin_prefs_bind_checkbox(const char *key, GtkWidget *button)
{
gtk_check_button_set_active(GTK_CHECK_BUTTON(button),
purple_prefs_get_bool(key));
g_signal_connect(G_OBJECT(button), "toggled",
G_CALLBACK(set_bool_pref), (char *)key);
}
static void
set_bool_switch_pref(GObject *obj, G_GNUC_UNUSED GParamSpec *pspec,
gpointer data)
{
const gchar *key = data;
purple_prefs_set_bool(key, gtk_switch_get_active(GTK_SWITCH(obj)));
}
void
pidgin_prefs_bind_switch(const gchar *key, GtkWidget *widget)
{
gtk_switch_set_active(GTK_SWITCH(widget), purple_prefs_get_bool(key));
g_signal_connect(widget, "notify::active",
G_CALLBACK(set_bool_switch_pref), (gchar *)key);
}
static void
set_expander_row_pref(GObject *obj, G_GNUC_UNUSED GParamSpec *pspec,
gpointer data)
{
const gchar *key = data;
gboolean enabled;
enabled = adw_expander_row_get_enable_expansion(ADW_EXPANDER_ROW(obj));
purple_prefs_set_bool(key, enabled);
}
void
pidgin_prefs_bind_expander_row(const gchar *key, GtkWidget *widget)
{
adw_expander_row_set_enable_expansion(ADW_EXPANDER_ROW(widget),
purple_prefs_get_bool(key));
g_signal_connect(widget, "notify::enable-expansion",
G_CALLBACK(set_expander_row_pref), (gchar *)key);
}
static void
vv_test_switch_page_cb(GtkStack *stack, G_GNUC_UNUSED GParamSpec *pspec,
gpointer data)
{
PidginVVPrefs *vv_prefs = data;
if (!g_str_equal(gtk_stack_get_visible_child_name(stack), "vv")) {
/* Disable any running test pipelines. */
pidgin_vv_prefs_disable_test_pipelines(vv_prefs);
}
}
/******************************************************************************
* GObject Implementation
*****************************************************************************/
static void
pidgin_prefs_window_finalize(GObject *obj) {
purple_prefs_disconnect_by_handle(obj);
G_OBJECT_CLASS(pidgin_prefs_window_parent_class)->finalize(obj);
}
static void
pidgin_prefs_window_class_init(PidginPrefsWindowClass *klass)
{
GObjectClass *obj_class = G_OBJECT_CLASS(klass);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
obj_class->finalize = pidgin_prefs_window_finalize;
gtk_widget_class_set_template_from_resource(
widget_class,
"/im/pidgin/Pidgin3/Prefs/prefs.ui"
);
/* Main window */
gtk_widget_class_bind_template_callback(widget_class,
vv_test_switch_page_cb);
}
static void
pidgin_prefs_window_init(PidginPrefsWindow *win)
{
gtk_widget_init_template(GTK_WIDGET(win));
}
/******************************************************************************
* API
*****************************************************************************/
void
pidgin_prefs_init(void)
{
purple_prefs_add_none(PIDGIN_PREFS_ROOT "");
purple_prefs_add_none("/plugins/gtk");
/* Plugins */
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/plugins");
purple_prefs_add_path_list(PIDGIN_PREFS_ROOT "/plugins/loaded", NULL);
/* File locations */
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/filelocations");
purple_prefs_add_path(PIDGIN_PREFS_ROOT "/filelocations/last_save_folder", "");
purple_prefs_add_path(PIDGIN_PREFS_ROOT "/filelocations/last_open_folder", "");
purple_prefs_add_path(PIDGIN_PREFS_ROOT "/filelocations/last_icon_folder", "");
/* Voice/Video */
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/audio");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/audio/src");
purple_prefs_add_string(PIDGIN_PREFS_ROOT "/vvconfig/audio/src/device", "");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/audio/sink");
purple_prefs_add_string(PIDGIN_PREFS_ROOT "/vvconfig/audio/sink/device", "");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/video");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/video/src");
purple_prefs_add_string(PIDGIN_PREFS_ROOT "/vvconfig/video/src/device", "");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/video");
purple_prefs_add_none(PIDGIN_PREFS_ROOT "/vvconfig/video/sink");
purple_prefs_add_string(PIDGIN_PREFS_ROOT "/vvconfig/video/sink/device", "");
pidgin_prefs_update_old();
}
void
pidgin_prefs_update_old(void)
{
const gchar *video_sink = NULL;
/* Rename some old prefs */
purple_prefs_rename(PIDGIN_PREFS_ROOT "/conversations/im/raise_on_events", "/plugins/gtk/X11/notify/method_raise");
purple_prefs_rename_boolean_toggle(PIDGIN_PREFS_ROOT "/conversations/ignore_colors",
PIDGIN_PREFS_ROOT "/conversations/show_incoming_formatting");
/* Remove some no-longer-used prefs */
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/auto_expand_contacts");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/button_style");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/grey_idle_buddies");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/raise_on_events");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/show_group_count");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/show_warning_level");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/tooltip_delay");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/x");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/blist/y");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/browsers");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/browsers/browser");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/browsers/command");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/browsers/place");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/browsers/manual_command");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/button_type");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/ctrl_enter_sends");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/enter_sends");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/escape_closes");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/html_shortcuts");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/icons_on_tabs");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/send_formatting");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/show_urls_as_links");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/use_custom_bgcolor");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/use_custom_fgcolor");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/use_custom_font");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/use_custom_size");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/chat/old_tab_complete");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/chat/tab_completion");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/im/hide_on_send");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/chat/color_nicks");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/chat/raise_on_events");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/ignore_fonts");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/ignore_font_sizes");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/passthrough_unknown_commands");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/debug/timestamps");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/idle");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/signon");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/silent_signon");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/command");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/conv_focus");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/chat_msg_recv");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/first_im_recv");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/got_attention");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/im_recv");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/join_chat");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/left_chat");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/login");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/logout");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/nick_said");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/pounce_default");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/send_chat_msg");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/send_im");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled/sent_attention");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/enabled");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/chat_msg_recv");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/first_im_recv");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/got_attention");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/im_recv");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/join_chat");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/left_chat");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/login");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/logout");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/nick_said");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/pounce_default");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/send_chat_msg");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/send_im");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file/sent_attention");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/file");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/method");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/mute");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound/theme");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/sound");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/away/queue_messages");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/away");
purple_prefs_remove("/plugins/gtk/docklet/queue_messages");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/chat/default_width");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/chat/default_height");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/im/default_width");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/conversations/im/default_height");
purple_prefs_rename(PIDGIN_PREFS_ROOT "/conversations/x",
PIDGIN_PREFS_ROOT "/conversations/im/x");
purple_prefs_rename(PIDGIN_PREFS_ROOT "/conversations/y",
PIDGIN_PREFS_ROOT "/conversations/im/y");
/* Fixup vvconfig plugin prefs */
if (purple_prefs_exists("/plugins/core/vvconfig/audio/src/device")) {
purple_prefs_set_string(PIDGIN_PREFS_ROOT "/vvconfig/audio/src/device",
purple_prefs_get_string("/plugins/core/vvconfig/audio/src/device"));
}
if (purple_prefs_exists("/plugins/core/vvconfig/audio/sink/device")) {
purple_prefs_set_string(PIDGIN_PREFS_ROOT "/vvconfig/audio/sink/device",
purple_prefs_get_string("/plugins/core/vvconfig/audio/sink/device"));
}
if (purple_prefs_exists("/plugins/core/vvconfig/video/src/device")) {
purple_prefs_set_string(PIDGIN_PREFS_ROOT "/vvconfig/video/src/device",
purple_prefs_get_string("/plugins/core/vvconfig/video/src/device"));
}
if (purple_prefs_exists("/plugins/gtk/vvconfig/video/sink/device")) {
purple_prefs_set_string(PIDGIN_PREFS_ROOT "/vvconfig/video/sink/device",
purple_prefs_get_string("/plugins/gtk/vvconfig/video/sink/device"));
}
video_sink = purple_prefs_get_string(PIDGIN_PREFS_ROOT "/vvconfig/video/sink/device");
if (purple_strequal(video_sink, "glimagesink") || purple_strequal(video_sink, "directdrawsink")) {
/* Accelerated sinks move to GTK GL. */
/* video_sink = "gtkglsink"; */
/* FIXME: I haven't been able to get gtkglsink to work yet: */
video_sink = "gtksink";
} else {
/* Everything else, including default will be moved to GTK sink. */
video_sink = "gtksink";
}
purple_prefs_set_string(PIDGIN_PREFS_ROOT "/vvconfig/video/sink/device", video_sink);
purple_prefs_remove("/plugins/core/vvconfig");
purple_prefs_remove("/plugins/gtk/vvconfig");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/vvconfig/audio/src/plugin");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/vvconfig/audio/sink/plugin");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/vvconfig/video/src/plugin");
purple_prefs_remove(PIDGIN_PREFS_ROOT "/vvconfig/video/sink/plugin");
}