HGKeeper

pidgin/pidgin

Fix several leaks in tests

14 months ago, Elliott Sales de Andrade

4e1bf25f5575

Fix several leaks in tests

All of these are specific to tests, not the library code.

For the moment, `protocol_xfer` still leaks connections (and anything they hold on to) because it is very difficult to disentangle them from the connection manager in the partially implemented state they are in.

This fixes leaks of options in the account option test (these two leaks occur for every test since they all leak the option):
```
61 (48 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 133 of 276
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48C3B2E: purple_account_option_new (purpleaccountoption.c:78)
by 0x4014AF: test_purple_account_option_copy_int (test_account_option.c:67)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401721: main (test_account_option.c:157)

61 (48 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 134 of 276
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48C3BC7: purple_account_option_copy (purpleaccountoption.c:93)
by 0x4014BF: test_purple_account_option_copy_int (test_account_option.c:68)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401721: main (test_account_option.c:157)
```
leaks in the credential manager test (times 3 for read/write/cancel tests):
```
69 (16 direct, 53 indirect) bytes in 1 blocks are definitely lost in loss record 2,427 of 3,503
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4A58168: g_malloc (gmem.c:130)
by 0x4A6FAB5: g_slice_alloc (gslice.c:1074)
by 0x4A700EC: g_slice_alloc0 (gslice.c:1100)
by 0x4A3BECB: g_error_allocate (gerror.c:710)
by 0x4A3C93F: UnknownInlinedFun (gerror.c:724)
by 0x4A3C93F: g_error_new_valist (gerror.c:766)
by 0x4BEE558: g_task_return_new_error (gtask.c:1941)
by 0x48D82C0: purple_credential_manager_read_password_async (purplecredentialmanager.c:492)
by 0x403634: test_purple_credential_manager_no_provider_read_password_idle (test_credential_manager.c:329)
by 0x4A4ECB1: g_idle_dispatch (gmain.c:6124)
by 0x4A4FCBE: UnknownInlinedFun (gmain.c:3444)
by 0x4A4FCBE: g_main_context_dispatch (gmain.c:4162)
by 0x4AA5597: g_main_context_iterate.constprop.0 (gmain.c:4238)
by 0x4A4F28E: g_main_loop_run (gmain.c:4438)
by 0x40369F: test_purple_credential_manager_no_provider_read_password_async (test_credential_manager.c:345)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x4048F6: main (test_credential_manager.c:695)
```
a leak in the image test:
```
161 bytes in 1 blocks are definitely lost in loss record 260 of 274
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4A55363: g_try_malloc (gmem.c:286)
by 0x4A3D630: UnknownInlinedFun (gfileutils.c:819)
by 0x4A3D630: UnknownInlinedFun (gfileutils.c:924)
by 0x4A3D630: g_file_get_contents (gfileutils.c:1027)
by 0x401890: test_image_new_from_file (test_image.c:144)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x40195D: main (test_image.c:172)
```
a leak in queued output stream test:
```
72 (40 direct, 32 indirect) bytes in 1 blocks are definitely lost in loss record 219 of 396
at 0x49D51EF: g_type_create_instance (gtype.c:1909)
by 0x49BAC1F: g_object_new_internal (gobject.c:2228)
by 0x49BC247: g_object_new_with_properties (gobject.c:2391)
by 0x49BCFF0: g_object_new (gobject.c:2037)
by 0x402003: test_queued_output_stream_push_bytes_async_error (test_queued_output_stream.c:219)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x402429: main (test_queued_output_stream.c:280)
```
and protocol xfer tests (times 3 for each test that creates a test protocol object):
```
112 (48 direct, 64 indirect) bytes in 1 blocks are definitely lost in loss record 3,430 of 3,698
at 0x49D51EF: g_type_create_instance (gtype.c:1909)
by 0x49BAC1F: g_object_new_internal (gobject.c:2228)
by 0x49BC247: g_object_new_with_properties (gobject.c:2391)
by 0x49BCFF0: g_object_new (gobject.c:2037)
by 0x40291C: test_purple_protocol_xfer_send_file_func (test_protocol_xfer.c:146)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x402B64: main (test_protocol_xfer.c:195)
```
and util tests (times 3 for each call to `purple_text_strip_mnemonic` in the test):
```
5 bytes in 1 blocks are definitely lost in loss record 5 of 247
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x49F7168: g_malloc (gmem.c:130)
by 0x491975B: purple_text_strip_mnemonic (util.c:895)
by 0x4015B0: test_util_text_strip_mnemonic (test_util.c:49)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401901: main (test_util.c:224)
```
and these leaks in any test that initializes the test UI:
```
4,104 bytes in 1 blocks are possibly lost in loss record 3,451 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5249A8B: UnknownInlinedFun (sqlite3.c:53675)
by 0x5249A8B: allocateTempSpace (sqlite3.c:70848)
by 0x52625A6: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:93857)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x529B324: sqlite3_exec (sqlite3.c:131002)
by 0x48FD558: purple_sqlite3_run_migration (purplesqlite3.c:37)
by 0x48FDBB4: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:195)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)

4,368 bytes in 1 blocks are possibly lost in loss record 3,453 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5240077: UnknownInlinedFun (sqlite3.c:53634)
by 0x5240077: pcache1FetchStage2 (sqlite3.c:54104)
by 0x5243E9C: UnknownInlinedFun (sqlite3.c:52671)
by 0x5243E9C: getPageNormal.lto_priv.0 (sqlite3.c:60628)
by 0x524A510: UnknownInlinedFun (sqlite3.c:60805)
by 0x524A510: btreeGetPage.lto_priv.0 (sqlite3.c:70289)
by 0x524C2F6: UnknownInlinedFun (sqlite3.c:71257)
by 0x524C2F6: sqlite3BtreeBeginTrans.lto_priv.0 (sqlite3.c:71647)
by 0x5266B3A: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:93532)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x48FD715: purple_sqlite3_get_schema_version (purplesqlite3.c:79)
by 0x48FD9DD: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:146)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)

4,368 bytes in 1 blocks are possibly lost in loss record 3,454 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5240077: UnknownInlinedFun (sqlite3.c:53634)
by 0x5240077: pcache1FetchStage2 (sqlite3.c:54104)
by 0x5243E9C: UnknownInlinedFun (sqlite3.c:52671)
by 0x5243E9C: getPageNormal.lto_priv.0 (sqlite3.c:60628)
by 0x52499BC: UnknownInlinedFun (sqlite3.c:60805)
by 0x52499BC: UnknownInlinedFun (sqlite3.c:70289)
by 0x52499BC: btreeGetUnusedPage (sqlite3.c:70432)
by 0x524F504: allocateBtreePage.lto_priv.0 (sqlite3.c:74604)
by 0x5256209: btreeCreateTable.lto_priv.0 (sqlite3.c:77830)
by 0x5265EB2: UnknownInlinedFun (sqlite3.c:77849)
by 0x5265EB2: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:96382)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x529B324: sqlite3_exec (sqlite3.c:131002)
by 0x48FD558: purple_sqlite3_run_migration (purplesqlite3.c:37)
by 0x48FDBB4: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:195)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)
```

Testing Done:
Ran tests in valgrind, and all above leaks were gone except for noted `protocol_xfer` issues, and a bunch of leaks of the `PurpleBuddy`-`PurpleContact` compatibility bindings, which will go away in their entirety eventually.

Reviewed at https://reviews.imfreedom.org/r/2385/

/* purple

* Purple is the legal property of its developers, whose names are too numerous

* to list here. Please refer to the COPYRIGHT file distributed with this

* source distribution.

* This program is free software; you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation; either version 2 of the License, or

* (at your option) any later version.

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

* You should have received a copy of the GNU General Public License

* along with this program; if not, see <https://www.gnu.org/licenses/>.

#include <glib/gi18n-lib.h>

#include "request.h"

#include "purpleprivate.h"

typedef struct {

char *id;

char *label;

char *type_hint;

gboolean visible;

gboolean required;

gboolean sensitive;

char *tooltip;

GClosure *validator;

} PurpleRequestFieldPrivate;

enum {

PROP_0,

PROP_ID,

PROP_LABEL,

PROP_VISIBLE,

PROP_SENSITIVE,

PROP_TYPE_HINT,

PROP_TOOLTIP,

PROP_REQUIRED,

PROP_FILLED,

PROP_VALID,

N_PROPERTIES,

};

static GParamSpec *properties[N_PROPERTIES] = {NULL, };

G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE(PurpleRequestField, purple_request_field,

G_TYPE_OBJECT)

/******************************************************************************

* Helpers

*****************************************************************************/

static void

purple_request_field_set_id(PurpleRequestField *field, const char *id) {

PurpleRequestFieldPrivate *priv = NULL;

priv = purple_request_field_get_instance_private(field);

g_free(priv->id);

priv->id = g_strdup(id);

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_ID]);

}

/******************************************************************************

* GObject Implementation

*****************************************************************************/

static void

purple_request_field_get_property(GObject *obj, guint param_id, GValue *value,

GParamSpec *pspec)

{

PurpleRequestField *field = PURPLE_REQUEST_FIELD(obj);

switch(param_id) {

case PROP_ID:

g_value_set_string(value, purple_request_field_get_id(field));

break;

case PROP_LABEL:

g_value_set_string(value, purple_request_field_get_label(field));

break;

case PROP_VISIBLE:

g_value_set_boolean(value, purple_request_field_is_visible(field));

break;

case PROP_SENSITIVE:

g_value_set_boolean(value,

purple_request_field_is_sensitive(field));

break;

case PROP_TYPE_HINT:

g_value_set_string(value,

purple_request_field_get_type_hint(field));

break;

case PROP_TOOLTIP:

g_value_set_string(value, purple_request_field_get_tooltip(field));

break;

case PROP_REQUIRED:

g_value_set_boolean(value,

purple_request_field_is_required(field));

break;

case PROP_FILLED:

g_value_set_boolean(value,

purple_request_field_is_filled(field));

break;

case PROP_VALID:

g_value_set_boolean(value,

purple_request_field_is_valid(field, NULL));

break;

default:

G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);

break;

}

static void

purple_request_field_set_property(GObject *obj, guint param_id,

const GValue *value, GParamSpec *pspec)

{

PurpleRequestField *field = PURPLE_REQUEST_FIELD(obj);

switch(param_id) {

case PROP_ID:

purple_request_field_set_id(field, g_value_get_string(value));

break;

case PROP_LABEL:

purple_request_field_set_label(field, g_value_get_string(value));

break;

case PROP_VISIBLE:

purple_request_field_set_visible(field,

g_value_get_boolean(value));

break;

case PROP_SENSITIVE:

purple_request_field_set_sensitive(field,

g_value_get_boolean(value));

break;

case PROP_TYPE_HINT:

purple_request_field_set_type_hint(field,

g_value_get_string(value));

break;

case PROP_TOOLTIP:

purple_request_field_set_tooltip(field, g_value_get_string(value));

break;

case PROP_REQUIRED:

purple_request_field_set_required(field,

g_value_get_boolean(value));

break;

default:

G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);

break;

}

static void

purple_request_field_finalize(GObject *obj) {

PurpleRequestField *field = PURPLE_REQUEST_FIELD(obj);

PurpleRequestFieldPrivate *priv = NULL;

priv = purple_request_field_get_instance_private(field);

g_free(priv->id);

g_free(priv->label);

g_free(priv->type_hint);

g_free(priv->tooltip);

g_clear_pointer(&priv->validator, g_closure_unref);

G_OBJECT_CLASS(purple_request_field_parent_class)->finalize(obj);

}

static void

purple_request_field_init(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

priv = purple_request_field_get_instance_private(field);

priv->visible = TRUE;

priv->sensitive = TRUE;

}

static void

purple_request_field_class_init(PurpleRequestFieldClass *klass) {

GObjectClass *obj_class = G_OBJECT_CLASS(klass);

obj_class->finalize = purple_request_field_finalize;

obj_class->get_property = purple_request_field_get_property;

obj_class->set_property = purple_request_field_set_property;

/**

* PurpleRequestField:id:

* The ID of the field.

* Since: 3.0.0

properties[PROP_ID] = g_param_spec_string(

"id", "id",

"The ID of the field.",

NULL,

G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:label:

* The label of the field.

* Since: 3.0.0

properties[PROP_LABEL] = g_param_spec_string(

"label", "label",

"The label of the field.",

NULL,

G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:visible:

* Whether the field should be visible.

* Since: 3.0.0

properties[PROP_VISIBLE] = g_param_spec_boolean(

"visible", "visible",

"Whether the field should be visible.",

TRUE,

G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:sensitive:

* Whether the field should be sensitive.

* Since: 3.0.0

properties[PROP_SENSITIVE] = g_param_spec_boolean(

"sensitive", "sensitive",

"Whether the field should be sensitive.",

TRUE,

G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:type-hint:

* The type hint of the field.

* Since: 3.0.0

properties[PROP_TYPE_HINT] = g_param_spec_string(

"type-hint", "type-hint",

"The type hint of the field.",

NULL,

G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:tooltip:

* The tooltip of the field.

* Since: 3.0.0

properties[PROP_TOOLTIP] = g_param_spec_string(

"tooltip", "tooltip",

"The tooltip of the field.",

NULL,

G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:required:

* Whether the field is required to complete the request.

* Since: 3.0.0

properties[PROP_REQUIRED] = g_param_spec_boolean(

"required", "required",

"Whether the field is required to complete the request.",

FALSE,

G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:filled:

* Whether the field has been filled.

* Since: 3.0.0

properties[PROP_FILLED] = g_param_spec_boolean(

"filled", "filled",

"Whether the field has been filled.",

TRUE,

G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);

/**

* PurpleRequestField:valid:

* Whether the field has a valid value.

* Since: 3.0.0

properties[PROP_VALID] = g_param_spec_boolean(

"valid", "valid",

"Whether the field has a valid value.",

TRUE,

G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);

g_object_class_install_properties(obj_class, N_PROPERTIES, properties);

}

/******************************************************************************

* Public API

*****************************************************************************/

void

purple_request_field_set_label(PurpleRequestField *field, const char *label)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

g_free(priv->label);

priv->label = g_strdup(label);

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_LABEL]);

}

void

purple_request_field_set_visible(PurpleRequestField *field, gboolean visible)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

priv->visible = visible;

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_VISIBLE]);

}

void

purple_request_field_set_type_hint(PurpleRequestField *field,

const char *type_hint)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

g_free(priv->type_hint);

priv->type_hint = g_strdup(type_hint);

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_TYPE_HINT]);

}

void

purple_request_field_set_tooltip(PurpleRequestField *field, const char *tooltip)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

g_free(priv->tooltip);

priv->tooltip = g_strdup(tooltip);

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_TOOLTIP]);

}

void

purple_request_field_set_required(PurpleRequestField *field, gboolean required)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

if(priv->required == required) {

return;

}

priv->required = required;

g_object_freeze_notify(G_OBJECT(field));

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_REQUIRED]);

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_VALID]);

g_object_thaw_notify(G_OBJECT(field));

}

const char *

purple_request_field_get_id(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), NULL);

priv = purple_request_field_get_instance_private(field);

return priv->id;

}

const char *

purple_request_field_get_label(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), NULL);

priv = purple_request_field_get_instance_private(field);

return priv->label;

}

gboolean

purple_request_field_is_visible(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), FALSE);

priv = purple_request_field_get_instance_private(field);

return priv->visible;

}

const char *

purple_request_field_get_type_hint(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), NULL);

priv = purple_request_field_get_instance_private(field);

return priv->type_hint;

}

const char *

purple_request_field_get_tooltip(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), NULL);

priv = purple_request_field_get_instance_private(field);

return priv->tooltip;

}

gboolean

purple_request_field_is_required(PurpleRequestField *field) {

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), FALSE);

priv = purple_request_field_get_instance_private(field);

return priv->required;

}

gboolean

purple_request_field_is_filled(PurpleRequestField *field) {

PurpleRequestFieldClass *klass = NULL;

gboolean filled = TRUE;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), FALSE);

klass = PURPLE_REQUEST_FIELD_GET_CLASS(field);

if(klass != NULL && klass->is_filled != NULL) {

filled = klass->is_filled(field);

}

return filled;

}

void

purple_request_field_set_validator(PurpleRequestField *field,

PurpleRequestFieldValidator validator,

gpointer user_data,

GDestroyNotify destroy_data)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

g_clear_pointer(&priv->validator, g_closure_unref);

if(validator != NULL) {

priv->validator = g_cclosure_new(G_CALLBACK(validator), user_data,

(GClosureNotify)G_CALLBACK(destroy_data));

g_closure_ref(priv->validator);

g_closure_sink(priv->validator);

g_closure_set_marshal(priv->validator, g_cclosure_marshal_generic);

}

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_VALID]);

}

gboolean

purple_request_field_is_valid(PurpleRequestField *field, gchar **errmsg)

{

PurpleRequestFieldClass *klass = NULL;

PurpleRequestFieldPrivate *priv = NULL;

gboolean valid = TRUE;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), FALSE);

if(errmsg != NULL) {

*errmsg = NULL;

}

klass = PURPLE_REQUEST_FIELD_GET_CLASS(field);

if(klass != NULL && klass->is_valid != NULL) {

valid = klass->is_valid(field, errmsg);

}

priv = purple_request_field_get_instance_private(field);

if(valid && priv->validator != NULL) {

GValue result = G_VALUE_INIT;

GValue params[] = {G_VALUE_INIT, G_VALUE_INIT};

g_value_init(&result, G_TYPE_BOOLEAN);

g_value_set_instance(g_value_init(&params[0],

PURPLE_TYPE_REQUEST_FIELD),

field);

g_value_set_pointer(g_value_init(&params[1], G_TYPE_POINTER), errmsg);

g_closure_invoke(priv->validator, &result,

G_N_ELEMENTS(params), params, NULL);

valid = g_value_get_boolean(&result);

g_value_unset(&result);

for(gsize i = 0; i < G_N_ELEMENTS(params); i++) {

g_value_unset(&params[i]);

}

if(valid && purple_request_field_is_required(field) &&

!purple_request_field_is_filled(field))

{

if(errmsg != NULL) {

*errmsg = g_strdup(_("Required field is not filled."));

}

valid = FALSE;

}

if(!valid && errmsg != NULL && *errmsg == NULL) {

*errmsg = g_strdup(_("Validation failed without setting an error "

"message."));

}

return valid;

}

void

purple_request_field_set_sensitive(PurpleRequestField *field,

gboolean sensitive)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_if_fail(PURPLE_IS_REQUEST_FIELD(field));

priv = purple_request_field_get_instance_private(field);

priv->sensitive = sensitive;

g_object_notify_by_pspec(G_OBJECT(field), properties[PROP_SENSITIVE]);

}

gboolean

purple_request_field_is_sensitive(PurpleRequestField *field)

{

PurpleRequestFieldPrivate *priv = NULL;

g_return_val_if_fail(PURPLE_IS_REQUEST_FIELD(field), FALSE);

priv = purple_request_field_get_instance_private(field);

return priv->sensitive;

}