HGKeeper

pidgin/pidgin

Fix several leaks in tests

14 months ago, Elliott Sales de Andrade

4e1bf25f5575

Fix several leaks in tests

All of these are specific to tests, not the library code.

For the moment, `protocol_xfer` still leaks connections (and anything they hold on to) because it is very difficult to disentangle them from the connection manager in the partially implemented state they are in.

This fixes leaks of options in the account option test (these two leaks occur for every test since they all leak the option):
```
61 (48 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 133 of 276
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48C3B2E: purple_account_option_new (purpleaccountoption.c:78)
by 0x4014AF: test_purple_account_option_copy_int (test_account_option.c:67)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401721: main (test_account_option.c:157)

61 (48 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss record 134 of 276
at 0x4848464: calloc (vg_replace_malloc.c:1340)
by 0x49F75F0: g_malloc0 (gmem.c:163)
by 0x48C3BC7: purple_account_option_copy (purpleaccountoption.c:93)
by 0x4014BF: test_purple_account_option_copy_int (test_account_option.c:68)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401721: main (test_account_option.c:157)
```
leaks in the credential manager test (times 3 for read/write/cancel tests):
```
69 (16 direct, 53 indirect) bytes in 1 blocks are definitely lost in loss record 2,427 of 3,503
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4A58168: g_malloc (gmem.c:130)
by 0x4A6FAB5: g_slice_alloc (gslice.c:1074)
by 0x4A700EC: g_slice_alloc0 (gslice.c:1100)
by 0x4A3BECB: g_error_allocate (gerror.c:710)
by 0x4A3C93F: UnknownInlinedFun (gerror.c:724)
by 0x4A3C93F: g_error_new_valist (gerror.c:766)
by 0x4BEE558: g_task_return_new_error (gtask.c:1941)
by 0x48D82C0: purple_credential_manager_read_password_async (purplecredentialmanager.c:492)
by 0x403634: test_purple_credential_manager_no_provider_read_password_idle (test_credential_manager.c:329)
by 0x4A4ECB1: g_idle_dispatch (gmain.c:6124)
by 0x4A4FCBE: UnknownInlinedFun (gmain.c:3444)
by 0x4A4FCBE: g_main_context_dispatch (gmain.c:4162)
by 0x4AA5597: g_main_context_iterate.constprop.0 (gmain.c:4238)
by 0x4A4F28E: g_main_loop_run (gmain.c:4438)
by 0x40369F: test_purple_credential_manager_no_provider_read_password_async (test_credential_manager.c:345)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x4048F6: main (test_credential_manager.c:695)
```
a leak in the image test:
```
161 bytes in 1 blocks are definitely lost in loss record 260 of 274
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4A55363: g_try_malloc (gmem.c:286)
by 0x4A3D630: UnknownInlinedFun (gfileutils.c:819)
by 0x4A3D630: UnknownInlinedFun (gfileutils.c:924)
by 0x4A3D630: g_file_get_contents (gfileutils.c:1027)
by 0x401890: test_image_new_from_file (test_image.c:144)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x40195D: main (test_image.c:172)
```
a leak in queued output stream test:
```
72 (40 direct, 32 indirect) bytes in 1 blocks are definitely lost in loss record 219 of 396
at 0x49D51EF: g_type_create_instance (gtype.c:1909)
by 0x49BAC1F: g_object_new_internal (gobject.c:2228)
by 0x49BC247: g_object_new_with_properties (gobject.c:2391)
by 0x49BCFF0: g_object_new (gobject.c:2037)
by 0x402003: test_queued_output_stream_push_bytes_async_error (test_queued_output_stream.c:219)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x402429: main (test_queued_output_stream.c:280)
```
and protocol xfer tests (times 3 for each test that creates a test protocol object):
```
112 (48 direct, 64 indirect) bytes in 1 blocks are definitely lost in loss record 3,430 of 3,698
at 0x49D51EF: g_type_create_instance (gtype.c:1909)
by 0x49BAC1F: g_object_new_internal (gobject.c:2228)
by 0x49BC247: g_object_new_with_properties (gobject.c:2391)
by 0x49BCFF0: g_object_new (gobject.c:2037)
by 0x40291C: test_purple_protocol_xfer_send_file_func (test_protocol_xfer.c:146)
by 0x4A7DC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A7DC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A7D9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A7E181: g_test_run_suite (gtestutils.c:3115)
by 0x4A766EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A766EC: g_test_run (gtestutils.c:2221)
by 0x402B64: main (test_protocol_xfer.c:195)
```
and util tests (times 3 for each call to `purple_text_strip_mnemonic` in the test):
```
5 bytes in 1 blocks are definitely lost in loss record 5 of 247
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x49F7168: g_malloc (gmem.c:130)
by 0x491975B: purple_text_strip_mnemonic (util.c:895)
by 0x4015B0: test_util_text_strip_mnemonic (test_util.c:49)
by 0x4A1CC7D: UnknownInlinedFun (gtestutils.c:2933)
by 0x4A1CC7D: g_test_run_suite_internal (gtestutils.c:3021)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1C9E4: g_test_run_suite_internal (gtestutils.c:3038)
by 0x4A1D181: g_test_run_suite (gtestutils.c:3115)
by 0x4A156EC: UnknownInlinedFun (gtestutils.c:2234)
by 0x4A156EC: g_test_run (gtestutils.c:2221)
by 0x401901: main (test_util.c:224)
```
and these leaks in any test that initializes the test UI:
```
4,104 bytes in 1 blocks are possibly lost in loss record 3,451 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5249A8B: UnknownInlinedFun (sqlite3.c:53675)
by 0x5249A8B: allocateTempSpace (sqlite3.c:70848)
by 0x52625A6: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:93857)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x529B324: sqlite3_exec (sqlite3.c:131002)
by 0x48FD558: purple_sqlite3_run_migration (purplesqlite3.c:37)
by 0x48FDBB4: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:195)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)

4,368 bytes in 1 blocks are possibly lost in loss record 3,453 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5240077: UnknownInlinedFun (sqlite3.c:53634)
by 0x5240077: pcache1FetchStage2 (sqlite3.c:54104)
by 0x5243E9C: UnknownInlinedFun (sqlite3.c:52671)
by 0x5243E9C: getPageNormal.lto_priv.0 (sqlite3.c:60628)
by 0x524A510: UnknownInlinedFun (sqlite3.c:60805)
by 0x524A510: btreeGetPage.lto_priv.0 (sqlite3.c:70289)
by 0x524C2F6: UnknownInlinedFun (sqlite3.c:71257)
by 0x524C2F6: sqlite3BtreeBeginTrans.lto_priv.0 (sqlite3.c:71647)
by 0x5266B3A: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:93532)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x48FD715: purple_sqlite3_get_schema_version (purplesqlite3.c:79)
by 0x48FD9DD: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:146)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)

4,368 bytes in 1 blocks are possibly lost in loss record 3,454 of 3,457
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x5235B67: sqlite3MemMalloc.lto_priv.0 (sqlite3.c:25493)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29181)
by 0x5232797: UnknownInlinedFun (sqlite3.c:29227)
by 0x5232797: sqlite3Malloc.lto_priv.0 (sqlite3.c:29221)
by 0x523BD8B: pcache1Alloc.lto_priv.0 (sqlite3.c:53546)
by 0x5240077: UnknownInlinedFun (sqlite3.c:53634)
by 0x5240077: pcache1FetchStage2 (sqlite3.c:54104)
by 0x5243E9C: UnknownInlinedFun (sqlite3.c:52671)
by 0x5243E9C: getPageNormal.lto_priv.0 (sqlite3.c:60628)
by 0x52499BC: UnknownInlinedFun (sqlite3.c:60805)
by 0x52499BC: UnknownInlinedFun (sqlite3.c:70289)
by 0x52499BC: btreeGetUnusedPage (sqlite3.c:70432)
by 0x524F504: allocateBtreePage.lto_priv.0 (sqlite3.c:74604)
by 0x5256209: btreeCreateTable.lto_priv.0 (sqlite3.c:77830)
by 0x5265EB2: UnknownInlinedFun (sqlite3.c:77849)
by 0x5265EB2: sqlite3VdbeExec.lto_priv.0 (sqlite3.c:96382)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:87995)
by 0x525CBEE: UnknownInlinedFun (sqlite3.c:88056)
by 0x525CBEE: sqlite3_step (sqlite3.c:88045)
by 0x529B324: sqlite3_exec (sqlite3.c:131002)
by 0x48FD558: purple_sqlite3_run_migration (purplesqlite3.c:37)
by 0x48FDBB4: purple_sqlite3_run_migrations_from_resources (purplesqlite3.c:195)
by 0x48FDED9: purple_sqlite_history_adapter_run_migrations (purplesqlitehistoryadapter.c:69)
by 0x48FE7F0: purple_sqlite_history_adapter_activate (purplesqlitehistoryadapter.c:287)
by 0x48DB656: purple_history_adapter_activate (purplehistoryadapter.c:181)
by 0x48DC9BC: purple_history_manager_set_active (purplehistorymanager.c:308)
by 0x402BA8: test_ui_init_history (test_ui.c:132)
by 0x402C80: test_ui_purple_init (test_ui.c:167)
by 0x4027BB: main (test_contact.c:88)
```

Testing Done:
Ran tests in valgrind, and all above leaks were gone except for noted `protocol_xfer` issues, and a bunch of leaks of the `PurpleBuddy`-`PurpleContact` compatibility bindings, which will go away in their entirety eventually.

Reviewed at https://reviews.imfreedom.org/r/2385/

* finch

* Finch is the legal property of its developers, whose names are too numerous

* to list here. Please refer to the COPYRIGHT file distributed with this

* source distribution.

* This program is free software; you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation; either version 2 of the License, or

* (at your option) any later version.

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

* You should have received a copy of the GNU General Public License

* along with this program; if not, write to the Free Software

* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA

#include <glib/gi18n-lib.h>

#include <purple.h>

#include <gnt.h>

#include "gntnotify.h"

static void

notify_msg_window_destroy_cb(GntWidget *window, PurpleNotifyType type)

{

purple_notify_close(type, window);

}

static void *

finch_notify_common(PurpleNotifyType ntype, PurpleNotifyMessageType msgtype,

const char *title, const char *primary,

const char *secondary,

G_GNUC_UNUSED PurpleRequestCommonParameters *cpar)

{

GntWidget *window, *button;

GntTextFormatFlags pf = 0, sf = 0;

switch (msgtype)

{

case PURPLE_NOTIFY_MSG_ERROR:

sf |= GNT_TEXT_FLAG_BOLD;

/* fall through */

case PURPLE_NOTIFY_MSG_WARNING:

pf |= GNT_TEXT_FLAG_UNDERLINE;

/* fall through */

case PURPLE_NOTIFY_MSG_INFO:

pf |= GNT_TEXT_FLAG_BOLD;

break;

}

window = gnt_window_box_new(FALSE, TRUE);

gnt_box_set_title(GNT_BOX(window), title);

gnt_box_set_fill(GNT_BOX(window), FALSE);

gnt_box_set_alignment(GNT_BOX(window), GNT_ALIGN_MID);

gnt_box_set_pad(GNT_BOX(window), 0);

if (primary)

gnt_box_add_widget(GNT_BOX(window),

gnt_label_new_with_format(primary, pf));

button = gnt_button_new(_("OK"));

if (secondary) {

GntWidget *msg;

if (ntype == PURPLE_NOTIFY_FORMATTED) {

int width = -1, height = -1;

char *plain = (char*)secondary;

msg = gnt_text_view_new();

gnt_text_view_set_flag(GNT_TEXT_VIEW(msg), GNT_TEXT_VIEW_TOP_ALIGN | GNT_TEXT_VIEW_NO_SCROLL);

plain = purple_markup_strip_html(secondary);

if (!gnt_util_parse_xhtml_to_textview(secondary, GNT_TEXT_VIEW(msg)))

gnt_text_view_append_text_with_flags(GNT_TEXT_VIEW(msg), plain, sf);

gnt_text_view_attach_scroll_widget(GNT_TEXT_VIEW(msg), button);

gnt_util_get_text_bound(plain, &width, &height);

gnt_widget_set_size(msg, width + 3, height + 1);

if (plain != secondary)

g_free(plain);

} else {

msg = gnt_label_new_with_format(secondary, sf);

}

gnt_box_add_widget(GNT_BOX(window), msg);

g_object_set_data(G_OBJECT(window), "info-widget", msg);

}

gnt_box_add_widget(GNT_BOX(window), button);

g_signal_connect_swapped(G_OBJECT(button), "activate",

G_CALLBACK(gnt_widget_destroy), window);

g_signal_connect(G_OBJECT(window), "destroy",

G_CALLBACK(notify_msg_window_destroy_cb), GINT_TO_POINTER(ntype));

gnt_widget_show(window);

return window;

}

/* handle is, in all/most occasions, a GntWidget * */

static void finch_close_notify(PurpleNotifyType type, void *handle)

{

GntWidget *widget = handle;

if (!widget)

return;

widget = gnt_widget_get_toplevel(widget);

if (type == PURPLE_NOTIFY_SEARCHRESULTS)

purple_notify_searchresults_free(g_object_get_data(handle, "notify-results"));

#if 1

/* This did not seem to be necessary */

g_signal_handlers_disconnect_by_func(G_OBJECT(widget),

G_CALLBACK(notify_msg_window_destroy_cb), GINT_TO_POINTER(type));

#endif

gnt_widget_destroy(widget);

}

static void *

finch_notify_message(PurpleNotifyMessageType type, const char *title,

const char *primary, const char *secondary,

PurpleRequestCommonParameters *cpar)

{

return finch_notify_common(PURPLE_NOTIFY_MESSAGE, type, title, primary,

secondary, cpar);

}

static void *finch_notify_formatted(const char *title, const char *primary,

const char *secondary, const char *text)

{

char *xhtml = NULL;

char *t = g_strdup_printf("%s%s%s",

secondary ? secondary : "",

secondary ? "\n" : "",

text ? text : "");

void *ret;

purple_markup_html_to_xhtml(t, &xhtml, NULL);

ret = finch_notify_common(PURPLE_NOTIFY_FORMATTED,

PURPLE_NOTIFY_MSG_INFO, title, primary, xhtml, NULL);

g_free(t);

g_free(xhtml);

return ret;

}

/** User information. **/

static GHashTable *userinfo;

static char *

userinfo_hash(PurpleAccount *account, const char *who)

{

char key[256];

g_snprintf(key, sizeof(key), "%s - %s",

purple_contact_info_get_username(PURPLE_CONTACT_INFO(account)),

purple_normalize(account, who));

return g_utf8_strup(key, -1);

}

static void

remove_userinfo(G_GNUC_UNUSED GntWidget *widget, gpointer key)

{

g_hash_table_remove(userinfo, key);

}

static char *

purple_notify_user_info_get_xhtml(PurpleNotifyUserInfo *user_info)

{

GList *l;

GString *text;

text = g_string_new("");

for (l = purple_notify_user_info_get_entries(user_info)->head; l != NULL;

l = l->next) {

PurpleNotifyUserInfoEntry *user_info_entry = l->data;

PurpleNotifyUserInfoEntryType type = purple_notify_user_info_entry_get_entry_type(user_info_entry);

const char *label = purple_notify_user_info_entry_get_label(user_info_entry);

const char *value = purple_notify_user_info_entry_get_value(user_info_entry);

/* Handle the label/value pair itself */

if (type == PURPLE_NOTIFY_USER_INFO_ENTRY_SECTION_HEADER)

g_string_append(text, "");

if (label)

g_string_append_printf(text, "%s", label);

g_string_append(text, "");

if (label && value)

g_string_append(text, ": ");

if (value) {

char *strip = purple_markup_strip_html(value);

g_string_append(text, strip);

g_free(strip);

}

g_string_append(text, "");

if (type == PURPLE_NOTIFY_USER_INFO_ENTRY_SECTION_HEADER)

g_string_append(text, "");

else if (type == PURPLE_NOTIFY_USER_INFO_ENTRY_SECTION_BREAK)

g_string_append(text, "<HR/>");

g_string_append(text, " ");

}

g_string_append(text, "");

return g_string_free(text, FALSE);

}

static void *

finch_notify_userinfo(PurpleConnection *gc, const char *who, PurpleNotifyUserInfo *user_info)

{

char *primary;

char *info;

void *ui_handle;

char *key = userinfo_hash(purple_connection_get_account(gc), who);

info = purple_notify_user_info_get_xhtml(user_info);

ui_handle = g_hash_table_lookup(userinfo, key);

if (ui_handle != NULL) {

GntTextView *msg = GNT_TEXT_VIEW(g_object_get_data(G_OBJECT(ui_handle), "info-widget"));

char *strip = purple_markup_strip_html(info);

int tvw, tvh, width, height, ntvw, ntvh;

GntWidget *window;

ui_handle = window = gnt_widget_get_toplevel(GNT_WIDGET(ui_handle));

gnt_widget_get_size(window, &width, &height);

gnt_widget_get_size(GNT_WIDGET(msg), &tvw, &tvh);

gnt_text_view_clear(msg);

if (!gnt_util_parse_xhtml_to_textview(info, msg))

gnt_text_view_append_text_with_flags(msg, strip, GNT_TEXT_FLAG_NORMAL);

gnt_text_view_scroll(msg, 0);

gnt_util_get_text_bound(strip, &ntvw, &ntvh);

ntvw += 3;

ntvh++;

gnt_screen_resize_widget(window, width + MAX(0, ntvw - tvw), height + MAX(0, ntvh - tvh));

g_free(strip);

g_free(key);

} else {

primary = g_strdup_printf(_("Info for %s"), who);

ui_handle = finch_notify_formatted(_("Buddy Information"), primary, NULL, info);

g_hash_table_insert(userinfo, key, ui_handle);

g_free(primary);

g_signal_connect(G_OBJECT(ui_handle), "destroy", G_CALLBACK(remove_userinfo), key);

}

g_free(info);

return ui_handle;

}

static void

notify_button_activated(GntWidget *widget, PurpleNotifySearchButton *b)

{

GList *list = NULL;

PurpleAccount *account = g_object_get_data(G_OBJECT(widget), "notify-account");

gpointer data = g_object_get_data(G_OBJECT(widget), "notify-data");

list = gnt_tree_get_selection_text_list(GNT_TREE(g_object_get_data(G_OBJECT(widget), "notify-tree")));

b->callback(purple_account_get_connection(account), list, data);

g_list_free_full(list, g_free);

}

static void

finch_notify_sr_new_rows(G_GNUC_UNUSED PurpleConnection *gc,

PurpleNotifySearchResults *results, gpointer data)

{

GntWindow *window = GNT_WINDOW(data);

GntTree *tree = GNT_TREE(g_object_get_data(G_OBJECT(window), "tree-widget"));

GList *o;

GntTreeRow *prev = NULL;

gnt_tree_remove_all(GNT_TREE(tree));

for (o = results->rows; o; o = o->next)

{

gnt_tree_add_row_after(GNT_TREE(tree), o->data,

gnt_tree_create_row_from_list(GNT_TREE(tree), o->data),

NULL, prev);

prev = o->data;

}

static void

notify_sr_destroy_cb(GntWidget *window, G_GNUC_UNUSED gpointer data)

{

purple_notify_close(PURPLE_NOTIFY_SEARCHRESULTS, window);

}

static void *

finch_notify_searchresults(PurpleConnection *gc, const char *title,

const char *primary, const char *secondary,

PurpleNotifySearchResults *results, gpointer data)

{

GntWidget *window, *tree, *box, *button;

GList *iter;

int columns, i;

window = gnt_vbox_new(FALSE);

gnt_box_set_toplevel(GNT_BOX(window), TRUE);

gnt_box_set_title(GNT_BOX(window), title);

gnt_box_set_fill(GNT_BOX(window), TRUE);

gnt_box_set_pad(GNT_BOX(window), 0);

gnt_box_set_alignment(GNT_BOX(window), GNT_ALIGN_MID);

if (primary)

gnt_box_add_widget(GNT_BOX(window),

gnt_label_new_with_format(primary, GNT_TEXT_FLAG_BOLD));

if (secondary)

gnt_box_add_widget(GNT_BOX(window),

gnt_label_new_with_format(secondary, GNT_TEXT_FLAG_NORMAL));

columns = g_list_length(results->columns);

tree = gnt_tree_new_with_columns(columns);

gnt_tree_set_show_title(GNT_TREE(tree), TRUE);

gnt_box_add_widget(GNT_BOX(window), tree);

i = 0;

for (iter = results->columns; iter; iter = iter->next)

{

PurpleNotifySearchColumn *column = iter->data;

gnt_tree_set_column_title(GNT_TREE(tree), i, purple_notify_searchresult_column_get_title(column));

if (!purple_notify_searchresult_column_is_visible(column))

gnt_tree_set_column_visible(GNT_TREE(tree), i, FALSE);

i++;

}

box = gnt_hbox_new(TRUE);

for (iter = results->buttons; iter; iter = iter->next)

{

PurpleNotifySearchButton *b = iter->data;

const char *text;

switch (b->type)

{

case PURPLE_NOTIFY_BUTTON_LABELED:

text = b->label;

break;

case PURPLE_NOTIFY_BUTTON_CONTINUE:

text = _("Continue");

break;

case PURPLE_NOTIFY_BUTTON_ADD:

text = _("Add");

break;

case PURPLE_NOTIFY_BUTTON_INFO:

text = _("Info");

break;

case PURPLE_NOTIFY_BUTTON_IM:

text = _("IM");

break;

case PURPLE_NOTIFY_BUTTON_JOIN:

text = _("Join");

break;

case PURPLE_NOTIFY_BUTTON_INVITE:

text = _("Invite");

break;

default:

text = _("(none)");

}

button = gnt_button_new(text);

g_object_set_data(G_OBJECT(button), "notify-account", purple_connection_get_account(gc));

g_object_set_data(G_OBJECT(button), "notify-data", data);

g_object_set_data(G_OBJECT(button), "notify-tree", tree);

g_signal_connect(G_OBJECT(button), "activate",

G_CALLBACK(notify_button_activated), b);

gnt_box_add_widget(GNT_BOX(box), button);

}

gnt_box_add_widget(GNT_BOX(window), box);

g_signal_connect(G_OBJECT(tree), "destroy",

G_CALLBACK(notify_sr_destroy_cb), NULL);

g_object_set_data(G_OBJECT(window), "tree-widget", tree);

finch_notify_sr_new_rows(gc, results, window);

g_signal_connect(G_OBJECT(window), "destroy",

G_CALLBACK(notify_msg_window_destroy_cb), GINT_TO_POINTER(PURPLE_NOTIFY_SEARCHRESULTS));

gnt_widget_show(window);

g_object_set_data(G_OBJECT(window), "notify-results", results);

return window;

}

static void *

finch_notify_uri(const char *url)

{

return finch_notify_common(PURPLE_NOTIFY_URI, PURPLE_NOTIFY_MSG_INFO,

_("URI"), url, NULL, NULL);

}

static PurpleNotifyUiOps ops = {

.notify_message = finch_notify_message,

.notify_formatted = finch_notify_formatted,

.notify_searchresults = finch_notify_searchresults,

.notify_searchresults_new_rows = finch_notify_sr_new_rows,

.notify_userinfo = finch_notify_userinfo,

.notify_uri = finch_notify_uri,

.close_notify = finch_close_notify,

};

PurpleNotifyUiOps *

finch_notify_get_ui_ops(void)

{

return &ops;

}

void

finch_notify_init(void)

{

userinfo = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, NULL);

}

void

finch_notify_uninit(void) {

g_clear_pointer(&userinfo, g_hash_table_destroy);

}