HGKeeper

Fix incompatible type conversion errors
release-2.x.y
4 months ago, Elliott Sales de Andrade

488055ab5531

Fix incompatible type conversion errors

- A recent libxml2 changed its handler function to take a `const` pointer. It's
safe for us to have it, and them not, but the opposite way causes an implicit
cast warning.
- In relatively new GLib (many years now), `g_object_ref` casts its output to
match its input. This means we should not be casting to `G_OBJECT`, as that
is not the type it expects, and would translate to the output being `GObject`
instead of the original type.

This fixes the build in Fedora 40, which changes several incompatible pointer
conversion warnings into errors.

This patch is partially from the Fedora maintainer @yarda, with some corrections by me (to the `g_object_ref` portions.)

Testing Done:
Compiled in a Rawhide environment with this patch applied.

Bugs closed: PIDGIN-17850

Reviewed at https://reviews.imfreedom.org/r/2944/

# Makefile.mingw

# Description: Makefile to generate mo files

PIDGIN_TREE_TOP := ..

include $(PIDGIN_TREE_TOP)/libpurple/win32/global.mak

PACKAGE = pidgin

.SUFFIXES:

.SUFFIXES: .po .gmo

## SOURCES, OBJECTS

CATALOGS = $(patsubst %.po,%.gmo,$(wildcard *.po))

## RULES

.po.gmo:

rm -f $@ && $(GMSGFMT) --statistics -o $@ $<

## TARGETS

.PHONY: all install clean

all: $(CATALOGS)

install: all

mkdir -p $(PURPLE_INSTALL_PO_DIR)

@catalogs='$(CATALOGS)'; \

for cat in $$catalogs; do \

cat=`basename $$cat`; \

lang=`echo $$cat | sed 's/\.gmo$$//'`; \

dir=$(PURPLE_INSTALL_PO_DIR)/$$lang/LC_MESSAGES; \

mkdir -p $$dir; \

if test -r $$cat; then \

cp $$cat $$dir/$(PACKAGE).mo; \

echo "installing $$cat as $$dir/$(PACKAGE).mo"; \

else \

cp $(PURPLE_PO_TOP)/$$cat $$dir/$(PACKAGE).mo; \

echo "installing $(PURPLE_PO_TOP)/$$cat as" \

"$$dir/$(PACKAGE).mo"; \

fi; \

done

clean:

rm -f *.gmo

pidgin/pidgin