pidgin/pidgin

Fix incompatible type conversion errors
release-2.x.y
3 months ago, Elliott Sales de Andrade
488055ab5531
Fix incompatible type conversion errors

- A recent libxml2 changed its handler function to take a `const` pointer. It's
safe for us to have it, and them not, but the opposite way causes an implicit
cast warning.
- In relatively new GLib (many years now), `g_object_ref` casts its output to
match its input. This means we should not be casting to `G_OBJECT`, as that
is not the type it expects, and would translate to the output being `GObject`
instead of the original type.

This fixes the build in Fedora 40, which changes several incompatible pointer
conversion warnings into errors.

This patch is partially from the Fedora maintainer @yarda, with some corrections by me (to the `g_object_ref` portions.)

Testing Done:
Compiled in a Rawhide environment with this patch applied.

Bugs closed: PIDGIN-17850

Reviewed at https://reviews.imfreedom.org/r/2944/
/**
* @file gtkplugin.h GTK+ Plugin API
* @ingroup pidgin
*/
/* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#ifndef _PIDGINPLUGIN_H_
#define _PIDGINPLUGIN_H_
#include "pidgin.h"
#include "plugin.h"
typedef struct _PidginPluginUiInfo PidginPluginUiInfo;
/**
* A GTK+ UI structure for plugins.
*/
struct _PidginPluginUiInfo
{
GtkWidget *(*get_config_frame)(PurplePlugin *plugin);
int page_num; /**< Reserved */
/* padding */
void (*_pidgin_reserved1)(void);
void (*_pidgin_reserved2)(void);
void (*_pidgin_reserved3)(void);
void (*_pidgin_reserved4)(void);
};
#define PIDGIN_PLUGIN_TYPE PIDGIN_UI
#define PIDGIN_IS_PIDGIN_PLUGIN(plugin) \
((plugin)->info != NULL && (plugin)->info->ui_info != NULL && \
purple_strequal((plugin)->info->ui_requirement, PIDGIN_PLUGIN_TYPE))
#define PIDGIN_PLUGIN_UI_INFO(plugin) \
((PidginPluginUiInfo *)(plugin)->info->ui_info)
/**
* Returns the configuration frame widget for a GTK+ plugin, if one
* exists.
*
* @param plugin The plugin.
*
* @return The frame, if the plugin is a GTK+ plugin and provides a
* configuration frame.
*/
GtkWidget *pidgin_plugin_get_config_frame(PurplePlugin *plugin);
/**
* Saves all loaded plugins.
*/
void pidgin_plugins_save(void);
/**
* Shows the Plugins dialog
*/
void pidgin_plugin_dialog_show(void);
#endif /* _PIDGINPLUGIN_H_ */