pidgin/pidgin

Fix incompatible type conversion errors
release-2.x.y
3 months ago, Elliott Sales de Andrade
488055ab5531
Fix incompatible type conversion errors

- A recent libxml2 changed its handler function to take a `const` pointer. It's
safe for us to have it, and them not, but the opposite way causes an implicit
cast warning.
- In relatively new GLib (many years now), `g_object_ref` casts its output to
match its input. This means we should not be casting to `G_OBJECT`, as that
is not the type it expects, and would translate to the output being `GObject`
instead of the original type.

This fixes the build in Fedora 40, which changes several incompatible pointer
conversion warnings into errors.

This patch is partially from the Fedora maintainer @yarda, with some corrections by me (to the `g_object_ref` portions.)

Testing Done:
Compiled in a Rawhide environment with this patch applied.

Bugs closed: PIDGIN-17850

Reviewed at https://reviews.imfreedom.org/r/2944/
/**
* @file eventloop.c Purple Event Loop API
* @ingroup core
*/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "internal.h"
#include "eventloop.h"
static PurpleEventLoopUiOps *eventloop_ui_ops = NULL;
guint
purple_timeout_add(guint interval, GSourceFunc function, gpointer data)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->timeout_add(interval, function, data);
}
guint
purple_timeout_add_seconds(guint interval, GSourceFunc function, gpointer data)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
if (ops->timeout_add_seconds)
return ops->timeout_add_seconds(interval, function, data);
else
return ops->timeout_add(1000 * interval, function, data);
}
gboolean
purple_timeout_remove(guint tag)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->timeout_remove(tag);
}
guint
purple_input_add(int source, PurpleInputCondition condition, PurpleInputFunction func, gpointer user_data)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->input_add(source, condition, func, user_data);
}
gboolean
purple_input_remove(guint tag)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->input_remove(tag);
}
int
purple_input_get_error(int fd, int *error)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
if (ops->input_get_error)
{
int ret = ops->input_get_error(fd, error);
errno = *error;
return ret;
}
else
{
socklen_t len;
len = sizeof(*error);
return getsockopt(fd, SOL_SOCKET, SO_ERROR, error, &len);
}
}
void
purple_eventloop_set_ui_ops(PurpleEventLoopUiOps *ops)
{
eventloop_ui_ops = ops;
}
PurpleEventLoopUiOps *
purple_eventloop_get_ui_ops(void)
{
g_return_val_if_fail(eventloop_ui_ops != NULL, NULL);
return eventloop_ui_ops;
}