pidgin/pidgin

Always ref result of g_io_stream_get_{input,output}_stream.

2021-03-05, Elliott Sales de Andrade
44c107f92a65
Always ref result of g_io_stream_get_{input,output}_stream.

Sometimes we wrap those in other streams, sometimes not. This makes prpls inconsistent with each other on whether they unref their `GInputStream`/`GOutputStream` in prpl data during shutdown. Thus, ref it when it's not wrapped, so we can _always_ do an unref in the cleanup.

This fixes a read-after-free Jabber shutdown, and presumably one in Novell, since it appears to do the same thing.

Testing Done:
Ran with valgrind and see no invalid reads in jabber shutdown. Novell was not tested, but seems similar.

Reviewed at https://reviews.imfreedom.org/r/558/
/*
* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include <glib/gi18n-lib.h>
#include "pidgindialog.h"
#include "pidgincore.h"
struct _PidginDialog {
GtkDialog parent;
};
/******************************************************************************
* GObject Implementation
*****************************************************************************/
G_DEFINE_TYPE(PidginDialog, pidgin_dialog, GTK_TYPE_DIALOG)
static void
pidgin_dialog_init(PidginDialog *button) {
}
static void
pidgin_dialog_class_init(PidginDialogClass *klass) {
}
/******************************************************************************
* Public API
*****************************************************************************/
GtkWidget *
pidgin_dialog_new(const gchar *title, guint border_width, const gchar *role,
gboolean resizable)
{
if(title == NULL) {
title = PIDGIN_ALERT_TITLE;
}
return GTK_WIDGET(g_object_new(
PIDGIN_TYPE_DIALOG,
"title", title,
"border-width", border_width,
"role", role,
"resizable", resizable,
NULL));
}