pidgin/pidgin

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner
41e1147347a5
Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.
/**
* @file gtkwhiteboard.h The PidginWhiteboard frontend object
*/
/* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#ifndef _PIDGINWHITEBOARD_H_
#define _PIDGINWHITEBOARD_H_
#include "pidgin.h"
#include "whiteboard.h"
#define FULL_CIRCLE_DEGREES 23040
/* TODO: Make into an enum. */
#define BRUSH_STATE_UP 0
#define BRUSH_STATE_DOWN 1
#define BRUSH_STATE_MOTION 2
/* XXX: This seems duplicated with the Yahoo! Doodle prpl code.
* XXX: How should they work together? */
#define PALETTE_NUM_COLORS 7
/**
* A PidginWhiteboard
*/
typedef struct _PidginWhiteboard
{
PurpleWhiteboard *wb; /**< backend data for this whiteboard */
GtkWidget *window; /**< Window for the Doodle session */
GtkWidget *drawing_area; /**< Drawing area */
GdkPixmap *pixmap; /**< Memory for drawing area */
int width; /**< Canvas width */
int height; /**< Canvas height */
int brush_color; /**< Foreground color */
int brush_size; /**< Brush size */
} PidginWhiteboard;
#ifdef __cplusplus
extern "C" {
#endif /* __cplusplus */
/*****************************************************************************/
/** @name PidginWhiteboard API */
/*****************************************************************************/
/*@{*/
/**
* Gets the GtkWhiteboard UI Operations.
*
* @return The GtkWhiteboard UI Operations.
*/
PurpleWhiteboardUiOps *pidgin_whiteboard_get_ui_ops( void );
/*@}*/
#ifdef __cplusplus
}
#endif /* __cplusplus */
#endif /* _PIDGINWHITEBOARD_H_ */