HGKeeper

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner

41e1147347a5

Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.

#include "gtksourceview-marshal.h"

#include <glib-object.h>

#ifdef G_ENABLE_DEBUG

#define g_marshal_value_peek_boolean(v) g_value_get_boolean (v)

#define g_marshal_value_peek_char(v) g_value_get_char (v)

#define g_marshal_value_peek_uchar(v) g_value_get_uchar (v)

#define g_marshal_value_peek_int(v) g_value_get_int (v)

#define g_marshal_value_peek_uint(v) g_value_get_uint (v)

#define g_marshal_value_peek_long(v) g_value_get_long (v)

#define g_marshal_value_peek_ulong(v) g_value_get_ulong (v)

#define g_marshal_value_peek_int64(v) g_value_get_int64 (v)

#define g_marshal_value_peek_uint64(v) g_value_get_uint64 (v)

#define g_marshal_value_peek_enum(v) g_value_get_enum (v)

#define g_marshal_value_peek_flags(v) g_value_get_flags (v)

#define g_marshal_value_peek_float(v) g_value_get_float (v)

#define g_marshal_value_peek_double(v) g_value_get_double (v)

#define g_marshal_value_peek_string(v) (char*) g_value_get_string (v)

#define g_marshal_value_peek_param(v) g_value_get_param (v)

#define g_marshal_value_peek_boxed(v) g_value_get_boxed (v)

#define g_marshal_value_peek_pointer(v) g_value_get_pointer (v)

#define g_marshal_value_peek_object(v) g_value_get_object (v)

#else /* !G_ENABLE_DEBUG */

/* WARNING: This code accesses GValues directly, which is UNSUPPORTED API.

* Do not access GValues directly in your code. Instead, use the

* g_value_get_*() functions

#define g_marshal_value_peek_boolean(v) (v)->data[0].v_int

#define g_marshal_value_peek_char(v) (v)->data[0].v_int

#define g_marshal_value_peek_uchar(v) (v)->data[0].v_uint

#define g_marshal_value_peek_int(v) (v)->data[0].v_int

#define g_marshal_value_peek_uint(v) (v)->data[0].v_uint

#define g_marshal_value_peek_long(v) (v)->data[0].v_long

#define g_marshal_value_peek_ulong(v) (v)->data[0].v_ulong

#define g_marshal_value_peek_int64(v) (v)->data[0].v_int64

#define g_marshal_value_peek_uint64(v) (v)->data[0].v_uint64

#define g_marshal_value_peek_enum(v) (v)->data[0].v_long

#define g_marshal_value_peek_flags(v) (v)->data[0].v_ulong

#define g_marshal_value_peek_float(v) (v)->data[0].v_float

#define g_marshal_value_peek_double(v) (v)->data[0].v_double

#define g_marshal_value_peek_string(v) (v)->data[0].v_pointer

#define g_marshal_value_peek_param(v) (v)->data[0].v_pointer

#define g_marshal_value_peek_boxed(v) (v)->data[0].v_pointer

#define g_marshal_value_peek_pointer(v) (v)->data[0].v_pointer

#define g_marshal_value_peek_object(v) (v)->data[0].v_pointer

#endif /* !G_ENABLE_DEBUG */

/* VOID:VOID (gtksourceview-marshal.list:1) */

/* VOID:BOOLEAN (gtksourceview-marshal.list:2) */

/* VOID:BOXED (gtksourceview-marshal.list:3) */

/* VOID:BOXED,BOXED (gtksourceview-marshal.list:4) */

void

gtksourceview_marshal_VOID__BOXED_BOXED (GClosure *closure,

GValue *return_value,

guint n_param_values,

const GValue *param_values,

gpointer invocation_hint,

gpointer marshal_data)

{

typedef void (*GMarshalFunc_VOID__BOXED_BOXED) (gpointer data1,

gpointer arg_1,

gpointer arg_2,

gpointer data2);

g_return_if_fail (n_param_values == 3);

if (G_CCLOSURE_SWAP_DATA (closure))

{

data1 = closure->data;

data2 = g_value_peek_pointer (param_values + 0);

}

else

{

data1 = g_value_peek_pointer (param_values + 0);

data2 = closure->data;

}

callback = (GMarshalFunc_VOID__BOXED_BOXED) (marshal_data ? marshal_data : cc->callback);

callback (data1,

g_marshal_value_peek_boxed (param_values + 1),

g_marshal_value_peek_boxed (param_values + 2),

data2);

}

/* VOID:STRING (gtksourceview-marshal.list:5) */

pidgin/pidgin