pidgin/pidgin

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner
41e1147347a5
Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.
/*
* GtkIMHtmlToolbar
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*
*/
#ifndef _PIDGINIMHTMLTOOLBAR_H_
#define _PIDGINIMHTMLTOOLBAR_H_
#include <gtk/gtk.h>
#include "gtkimhtml.h"
#ifdef __cplusplus
extern "C" {
#endif
#define DEFAULT_FONT_FACE "Helvetica 12"
#define GTK_TYPE_IMHTMLTOOLBAR (gtk_imhtmltoolbar_get_type())
#define GTK_IMHTMLTOOLBAR(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), GTK_TYPE_IMHTMLTOOLBAR, GtkIMHtmlToolbar))
#define GTK_IMHTMLTOOLBAR_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass), GTK_TYPE_IMHTMLTOOLBAR, GtkIMHtmlToolbarClass))
#define GTK_IS_IMHTMLTOOLBAR(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj), GTK_TYPE_IMHTMLTOOLBAR))
#define GTK_IS_IMHTMLTOOLBAR_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), GTK_TYPE_IMHTMLTOOLBAR))
typedef struct _GtkIMHtmlToolbar GtkIMHtmlToolbar;
typedef struct _GtkIMHtmlToolbarClass GtkIMHtmlToolbarClass;
struct _GtkIMHtmlToolbar {
GtkHBox box;
GtkWidget *imhtml;
GtkTooltips *tooltips;
GtkWidget *bold;
GtkWidget *italic;
GtkWidget *underline;
GtkWidget *larger_size;
GtkWidget *normal_size;
GtkWidget *smaller_size;
GtkWidget *font;
GtkWidget *fgcolor;
GtkWidget *bgcolor;
GtkWidget *clear;
GtkWidget *image;
GtkWidget *link;
GtkWidget *smiley;
GtkWidget *font_dialog;
GtkWidget *fgcolor_dialog;
GtkWidget *bgcolor_dialog;
GtkWidget *link_dialog;
GtkWidget *smiley_dialog;
GtkWidget *image_dialog;
char *sml;
GtkWidget *strikethrough;
GtkWidget *insert_hr;
GtkWidget *call;
};
struct _GtkIMHtmlToolbarClass {
GtkHBoxClass parent_class;
};
GType gtk_imhtmltoolbar_get_type (void);
GtkWidget* gtk_imhtmltoolbar_new (void);
void gtk_imhtmltoolbar_attach (GtkIMHtmlToolbar *toolbar, GtkWidget *imhtml);
void gtk_imhtmltoolbar_associate_smileys (GtkIMHtmlToolbar *toolbar, const char *proto_id);
/**
* @since 2.7.0
*/
void gtk_imhtmltoolbar_switch_active_conversation(GtkIMHtmlToolbar *toolbar,
PurpleConversation *conv);
#ifdef __cplusplus
}
#endif
#endif /* _PIDGINIMHTMLTOOLBAR_H_ */