pidgin/pidgin

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner
41e1147347a5
Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.
#ifndef DBUS_API_SUBJECT_TO_CHANGE
#define DBUS_API_SUBJECT_TO_CHANGE
#endif
#include <stdio.h>
#include <stdlib.h>
#include "purple-client.h"
/*
This example demonstrates how to use libpurple-client to communicate
with purple. The names and signatures of functions provided by
libpurple-client are the same as those in purple. However, all
structures (such as PurpleAccount) are opaque, that is, you can only
use pointer to them. In fact, these pointers DO NOT actually point
to anything, they are just integer identifiers of assigned to these
structures by purple. So NEVER try to dereference these pointers.
Integer ids as disguised as pointers to provide type checking and
prevent mistakes such as passing an id of PurpleAccount when an id of
PurpleBuddy is expected. According to glib manual, this technique is
portable.
*/
int main (int argc, char **argv)
{
GList *alist, *node;
purple_init();
alist = purple_accounts_get_all();
for (node = alist; node != NULL; node = node->next)
{
PurpleAccount *account = (PurpleAccount*) node->data;
char *name = purple_account_get_username(account);
g_print("Name: %s\n", name);
g_free(name);
}
g_list_free(alist);
return 0;
}