pidgin/pidgin

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner
41e1147347a5
Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.
/**
* @file gntconv.h GNT Conversation API
* @ingroup finch
*/
/* finch
*
* Finch is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#ifndef _GNT_CONV_H
#define _GNT_CONV_H
#include <gnt.h>
#include <gntwidget.h>
#include <gntmenuitem.h>
#include "conversation.h"
/* Grabs the conv out of a PurpleConverstation */
#define FINCH_CONV(conv) ((FinchConv *)(conv)->ui_data)
/***************************************************************************
* @name GNT Conversations API
***************************************************************************/
/*@{*/
typedef struct _FinchConv FinchConv;
typedef struct _FinchConvChat FinchConvChat;
typedef struct _FinchConvIm FinchConvIm;
typedef enum
{
FINCH_CONV_NO_SOUND = 1 << 0,
} FinchConversationFlag;
struct _FinchConv
{
GList *list;
PurpleConversation *active_conv;
GntWidget *window; /* the container */
GntWidget *entry; /* entry */
GntWidget *tv; /* text-view */
GntWidget *menu;
GntWidget *info;
FinchConversationFlag flags;
union
{
FinchConvChat *chat;
FinchConvIm *im;
} u;
};
struct _FinchConvChat
{
GntWidget *userlist; /* the userlist */
void *pad1;
void *pad2;
};
struct _FinchConvIm
{
GntMenuItem *sendto;
void *something_for_later;
};
/**
* Get the ui-functions.
*
* @return The PurpleConversationUiOps populated with the appropriate functions.
*/
PurpleConversationUiOps *finch_conv_get_ui_ops(void);
/**
* Perform the necessary initializations.
*/
void finch_conversation_init(void);
/**
* Perform the necessary uninitializations.
*/
void finch_conversation_uninit(void);
/**
* Set a conversation as active in a contactized conversation
*
* @param conv The conversation to make active.
*/
void finch_conversation_set_active(PurpleConversation *conv);
/**
* Sets the information widget for the conversation window.
*
* @param conv The conversation.
* @param widget The widget containing the information. If @c NULL,
* the current information widget is removed.
*/
void finch_conversation_set_info_widget(PurpleConversation *conv, GntWidget *widget);
/*@}*/
#endif