pidgin/pidgin

Fix leaks in dynamic menus

15 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include "purplewhiteboarduiops.h"
/******************************************************************************
* Globals
*****************************************************************************/
static PurpleWhiteboardUiOps *ui_ops = NULL;
/******************************************************************************
* Helpers
*****************************************************************************/
static PurpleWhiteboardUiOps *
purple_whiteboard_ui_ops_copy(PurpleWhiteboardUiOps *ops) {
PurpleWhiteboardUiOps *ops_new = NULL;
g_return_val_if_fail(ops != NULL, NULL);
ops_new = g_new(PurpleWhiteboardUiOps, 1);
*ops_new = *ops;
return ops_new;
}
/******************************************************************************
* Public API
*****************************************************************************/
G_DEFINE_BOXED_TYPE(PurpleWhiteboardUiOps, purple_whiteboard_ui_ops,
purple_whiteboard_ui_ops_copy, g_free)
void
purple_whiteboard_set_ui_ops(PurpleWhiteboardUiOps *ops) {
ui_ops = ops;
}
void
purple_whiteboard_ui_ops_create(PurpleWhiteboard *whiteboard) {
if(ui_ops != NULL && ui_ops->create != NULL) {
ui_ops->create(whiteboard);
}
}
void
purple_whiteboard_ui_ops_destroy(PurpleWhiteboard *whiteboard) {
if(ui_ops != NULL && ui_ops->destroy != NULL) {
ui_ops->destroy(whiteboard);
}
}
void
purple_whiteboard_ui_ops_set_dimensions(PurpleWhiteboard *whiteboard,
gint width, gint height)
{
if(ui_ops != NULL && ui_ops->set_dimensions != NULL) {
ui_ops->set_dimensions(whiteboard, width, height);
}
}
void
purple_whiteboard_ui_ops_set_brush(PurpleWhiteboard *whiteboard, gint size,
gint color)
{
if(ui_ops != NULL && ui_ops->set_brush != NULL) {
ui_ops->set_brush(whiteboard, size, color);
}
}
void
purple_whiteboard_ui_ops_draw_point(PurpleWhiteboard *whiteboard, gint x,
gint y, gint color, gint size)
{
if(ui_ops != NULL && ui_ops->draw_point != NULL) {
ui_ops->draw_point(whiteboard, x, y, color, size);
}
}
void
purple_whiteboard_ui_ops_draw_line(PurpleWhiteboard *whiteboard, gint x1,
gint y1, gint x2, gint y2, gint color,
gint size)
{
if(ui_ops != NULL && ui_ops->draw_line != NULL) {
ui_ops->draw_line(whiteboard, x1, y1, x2, y2, color, size);
}
}
void
purple_whiteboard_ui_ops_clear(PurpleWhiteboard *whiteboard) {
if(ui_ops != NULL && ui_ops->clear != NULL) {
ui_ops->clear(whiteboard);
}
}