pidgin/pidgin

Fix leaks in dynamic menus

15 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#if !defined(PURPLE_GLOBAL_HEADER_INSIDE) && !defined(PURPLE_COMPILATION)
# error "only <purple.h> may be included directly"
#endif
#ifndef PURPLE_PROXY_INFO_H
#define PURPLE_PROXY_INFO_H
#include <glib.h>
#include <glib-object.h>
/**
* PurpleProxyType:
* @PURPLE_PROXY_TYPE_USE_GLOBAL: Use the global proxy information.
* @PURPLE_PROXY_TYPE_NONE: No proxy.
* @PURPLE_PROXY_TYPE_HTTP: HTTP proxy.
* @PURPLE_PROXY_TYPE_SOCKS4: SOCKS 4 proxy.
* @PURPLE_PROXY_TYPE_SOCKS5: SOCKS 5 proxy.
* @PURPLE_PROXY_TYPE_USE_ENVVAR: Use environmental settings.
* @PURPLE_PROXY_TYPE_TOR: Use a Tor proxy (SOCKS 5 really).
*
* A type of proxy connection.
*/
typedef enum {
PURPLE_PROXY_TYPE_USE_GLOBAL = -1,
PURPLE_PROXY_TYPE_NONE = 0,
PURPLE_PROXY_TYPE_HTTP,
PURPLE_PROXY_TYPE_SOCKS4,
PURPLE_PROXY_TYPE_SOCKS5,
PURPLE_PROXY_TYPE_USE_ENVVAR,
PURPLE_PROXY_TYPE_TOR
} PurpleProxyType;
G_BEGIN_DECLS
#define PURPLE_TYPE_PROXY_INFO (purple_proxy_info_get_type())
G_DECLARE_FINAL_TYPE(PurpleProxyInfo, purple_proxy_info, PURPLE, PROXY_INFO,
GObject)
/**
* purple_proxy_info_new:
*
* Creates a new proxy info instance.
*
* Returns: (transfer full): The new instance.
*/
PurpleProxyInfo *purple_proxy_info_new(void);
/**
* purple_proxy_info_set_proxy_type:
* @info: The instance.
* @proxy_type: The new type.
*
* Sets the type of @info.
*/
void purple_proxy_info_set_proxy_type(PurpleProxyInfo *info, PurpleProxyType proxy_type);
/**
* purple_proxy_info_get_proxy_type:
* @info: The instance.
*
* Gets the type of the proxy.
*
* Returns: The type of the proxy.
*/
PurpleProxyType purple_proxy_info_get_proxy_type(PurpleProxyInfo *info);
/**
* purple_proxy_info_set_hostname:
* @info: The instance.
* @hostname: The new hostname.
*
* Sets the hostname for the proxy.
*
* Since: 3.0.0
*/
void purple_proxy_info_set_hostname(PurpleProxyInfo *info, const gchar *hostname);
/**
* purple_proxy_info_get_hostname:
* @info: The instance.
*
* Gets the hostname of the proxy.
*
* Returns: The hostname.
*
* Since: 3.0.0
*/
const gchar *purple_proxy_info_get_hostname(PurpleProxyInfo *info);
/**
* purple_proxy_info_set_port:
* @info: The instance.
* @port: The new port.
*
* Sets the port for the proxy.
*/
void purple_proxy_info_set_port(PurpleProxyInfo *info, gint port);
/**
* purple_proxy_info_get_port:
* @info: The instance.
*
* Gets the port of the proxy.
*
* Returns: The port of the proxy.
*/
gint purple_proxy_info_get_port(PurpleProxyInfo *info);
/**
* purple_proxy_info_set_username:
* @info: The instance.
* @username: The new username.
*
* Sets the username of the proxy.
*/
void purple_proxy_info_set_username(PurpleProxyInfo *info, const gchar *username);
/**
* purple_proxy_info_get_username:
* @info: The instance.
*
* Gets the username of the proxy.
*
* Returns: The username of the proxy.
*/
const gchar *purple_proxy_info_get_username(PurpleProxyInfo *info);
/**
* purple_proxy_info_set_password:
* @info: The instance.
* @password: The new password.
*
* Sets the password for the proxy.
*/
void purple_proxy_info_set_password(PurpleProxyInfo *info, const gchar *password);
/**
* purple_proxy_info_get_password:
* @info: The instance.
*
* Gets the password of the proxy.
*
* Returns: The password of the proxy.
*/
const gchar *purple_proxy_info_get_password(PurpleProxyInfo *info);
G_END_DECLS
#endif /* PURPLE_PROXY_INFO_H */