pidgin/pidgin

Fix leaks in dynamic menus

15 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#if !defined(PURPLE_GLOBAL_HEADER_INSIDE) && !defined(PURPLE_COMPILATION)
# error "only <purple.h> may be included directly"
#endif
#ifndef PURPLE_PROTOCOL_IM_H
#define PURPLE_PROTOCOL_IM_H
#include <glib.h>
#include <glib-object.h>
#include <libpurple/connection.h>
#include <libpurple/purpleprotocol.h>
#define PURPLE_TYPE_PROTOCOL_IM (purple_protocol_im_get_type())
/**
* PurpleProtocolIM:
*
* #PurpleProtocolIM describes the API that protocols need to implement for
* handling one on one conversations.
*
* Since: 3.0.0
*/
G_DECLARE_INTERFACE(PurpleProtocolIM, purple_protocol_im, PURPLE, PROTOCOL_IM,
PurpleProtocol)
/**
* PurpleProtocolIMInterface:
* @send: This protocol function should return a positive value on
* success. If the message is too big to be sent, return
* <literal>-E2BIG</literal>. If the account is not connected,
* return <literal>-ENOTCONN</literal>. If the protocol is unable
* to send the message for another reason, return some other
* negative value. You can use one of the valid #errno values, or
* just big something. If the message should not be echoed to the
* conversation window, return 0.
* @send_typing: If this protocol requires the #PURPLE_IM_TYPING message to be
* sent repeatedly to signify that the user is still typing, then
* the protocol should return the number of seconds to wait before
* sending a subsequent notification. Otherwise the protocol
* should return 0.
*
* The protocol IM interface that needs to be implemented to send one to one
* messages.
*/
struct _PurpleProtocolIMInterface {
/*< private >*/
GTypeInterface parent;
/*< public >*/
gint (*send)(PurpleProtocolIM *im, PurpleConnection *connection,
PurpleMessage *msg);
guint (*send_typing)(PurpleProtocolIM *im, PurpleConnection *connection,
const gchar *name, PurpleIMTypingState state);
/*< private >*/
gpointer reserved[4];
};
G_BEGIN_DECLS
/**
* purple_protocol_im_send:
* @im: The #PurpleProtocolIM instance.
* @connection: The #PurpleConnection to use.
* @msg: The #PurpleMessage to send.
*
* Sends @msg out over @connection.
*
* Returns: >= 0 on success, or < 0 on error. If 0 is returned the message
* should not be output locally.
*/
gint purple_protocol_im_send(PurpleProtocolIM *im,
PurpleConnection *connection,
PurpleMessage *msg);
/**
* purple_protocol_im_send_typing:
* @im: The #PurpleProtocolIM instance.
* @connection: The #PurpleConversation to use.
* @name: The name of the user to send a typing notification to.
* @state: The #PurpleIMTypingState Value.
*
* If this protocol requires the #PURPLE_IM_TYPING message to be sent
* repeatedly to signify that the user is still typing, then the protocol
* should return the number of seconds to wait before sending a subsequent
* notification. Otherwise the protocol should return 0.
*
* Returns: A quiet-period, specified in seconds, where Purple will not send
* any additional typing notification messages. Most protocols should
* return 0, which means that no additional #PURPLE_IM_TYPING messages
* need to be sent. If this is 5, for example, then Purple will wait
* five seconds, and if the Purple user is still typing then Purple
* will send another #PURPLE_IM_TYPING message.
*/
guint purple_protocol_im_send_typing(PurpleProtocolIM *im,
PurpleConnection *connection,
const gchar *name,
PurpleIMTypingState state);
G_END_DECLS
#endif /* PURPLE_PROTOCOL_IM_H */